1564841 - Add ability to filter "Imported" strings

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P2)

Description

[Matjaz Horvat [:mathjazz]]

Translation authors filter should include an entry for translations that don't have an author.

Comment 1

[Gabriela [:gaby2300]]

This would be very useful indeed!

Comment 2

[Marcelo Ghelman]

Hi Majaz,

In order to review all translations made by other translators, I filter by author, one by one.
Adding a filter by no author will resolve my need to review imported strings.
But to do this work, it would be even easier if there was an option to appear only the strings approved by the author, instead of all strings that had her/his contribution.
Is it possible?

Comment 3

[Matjaz Horvat [:mathjazz]]

Marcelo,

As the name suggests, the "Translation Authors" filter filters by users who authored the translations.

Adding the ability to filter by reviewers (users who approved, maybe also rejected translations) is a bigger feature, which also requires some design changes. Please file a separate bug for it.

Comment 4

[Marcelo Ghelman]

Matjaz,

I'm afraid I didn't explain correctly.
I didn't mean add filter by reviewer.

For example, if I filter by Cynthia, appear all strings that have her contribution, either approved or rejected.
What I asked for is an option to appear only the strings whose Cynthia's contributions are approved.
With this option, I'd be able to view only IMPORTED (or any author) translations that was not replaced by another author's approved translation.
This will easy the reviewing process.

Comment 5

[Matjaz Horvat [:mathjazz]]

Marcelo,

Thanks for clarifying this. I wonder if combining the Author filter and the Translated status filter would be helpful.

You need to click on the filter icon to select multiple filters, for example:
https://pontoon.mozilla.org/translate/pt-BR/firefox/all-resources/?status=translated&author=cynthiacpereira%40gmail.com

I know this is not the same as what you are asking for, because it also includes approved strings for which Cynthia contributed rejected and unreviewed translations. But it might still be helpful.

If not, feel free to file a separate bug and let's keep this one for the Imported filter.

Comment 6

[Pachi]

Hello, I am an Outreachy applicant and would like to work on this issue

Comment 7

[Albiona]

Hi, I am an outreachy applicant, if no one else will not work on this issue, I might continue.

Comment 8

[Matjaz Horvat [:mathjazz]]

Hi Pachi, I've assigned the bug to you. Please let me know if you have any questions, either here or in #pontoon on IRC.

You can start by installing Pontoon locally using Docker.

Once you have a working local environment, please make sure to read our contribution docs. It contains information on how to style code, how to run tests, how to name your commits, etc. All the things you need to know if you want your work to be merged into Pontoon!

--

Albiona, we have several other mentored bugs available. For instance, you can have a look at bug 1564837 or you can find me in #pontoon on IRC and we can find something that will suit you together.

Comment 9

[Matjaz Horvat [:mathjazz]]

We're getting lots of requests by Outreachy participants, so we often run out of Mentored bugs. We've decided to unassign all Mentored bugs until the assignee sets up a development environment.
​
Please send us a screenshot of your working development environment via #pontoon on Mozilla IRC and we'll assign you a Mentored bug afterwards.
​
Thanks for understanding!

Comment 10

[Raj Sandhu (:rsandhu)]

Hi all, I'm new here and an Outreachy participant. Judging from my User Activity Report, it looks like I've been assigned this bug. Is this correct?

Comment 11

[Matjaz Horvat [:mathjazz]]

Now it is. :) I see you've already set up the environment.

Comment 12

[Raj Sandhu (:rsandhu)]

Yes, and I feel as clueless as a kid sitting in a 747 cockpit, trying on the captain's hat. But I'm looking through the documentation and will have plenty of questions, the answers to which will hopefully have me flying soon. :D

Comment 13

[Matjaz Horvat [:mathjazz]]

Attachment: Styling of the "Imported" filter

Comment 14

[Matjaz Horvat [:mathjazz]]

Assigning to Anastasia as agreed with Raj over email.

Frontend code:
https://github.com/mozilla/pontoon/blob/master/frontend/src/modules/search/components/FiltersPanel.js#L327

Backend code:
https://github.com/mozilla/pontoon/blob/master/pontoon/base/models.py#L2155

Comment 15

[Karskaya]

Hi @mathjazz! I'm ready to try this. Can I?

Comment 16

[Karskaya]

@mathjazz I have a question: this Imported(System User) is it exist somewhere in the system?
Because I do not see it in a list of users(props.authorData array).
Should it be done by just adding additional html block with unexisting virtual 'Imported' user?
Or it can be received into props.authorData array somehow?

As I understood all imported translations will be filtered if it will be possible to filter by empty email here:
https://github.com/mozilla/pontoon/blob/82190d5bdf065dec294153e95fc850b13a58716c/pontoon/base/models.py#L2175
Am I right?

Comment 17

[Matjaz Horvat [:mathjazz]]

We don't have such System user.

First, you'll need to make sure that the "Imported" System User is returned by the API:
https://github.com/mozilla/pontoon/blob/master/frontend/src/core/api/filter.js

Right now the API excludes translations for which the user is None:
https://github.com/mozilla/pontoon/blob/master/pontoon/contributors/utils.py#L59

Instead of empty email, we should use something like "Imported" here:
https://github.com/mozilla/pontoon/blob/82190d5bdf065dec294153e95fc850b13a58716c/pontoon/base/models.py#L2175

Comment 18

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1465

Comment 19

[Matjaz Horvat [:mathjazz]]

https://github.com/mozilla/pontoon/commit/7e49b93dd10deba32347db61e398a71e5500aae4