1564877 - The Avatar picture is not restore to the default one, after you are sign out from your firefox account

Status: VERIFIED FIXED

(Firefox :: Firefox Accounts, defect)

Description

[ovidiu boca[:Ovidiu]]

Affected versions

• Beta 69.0b3 and Nightly 70.0a1(2019-07-09)
  This issue is not reproducible on FF Release 68.

Affected platforms

• Tested on Mac OS X 10.14 and Windows 10

Steps to reproduce

Prerequisites: You need to have a picture set to your sync account.

1. Log into your sync account. - the avatar picture is displayed.
2. Log out from your sync account.

Expected result

• The avatar icon is set to default.

Actual result

• The avatar icon is not set to default, your avatar picture is still displayed.

Regression range
Last good revision: 01f72d6cc13b754b8250cc87fd1051714ce9a02b
First bad revision: 4a75d6afa43e263091d2bb2a40c30834d1212445
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=01f72d6cc13b754b8250cc87fd1051714ce9a02b&tochange=4a75d6afa43e263091d2bb2a40c30834d1212445

• Potentially regressed by: bug 1555771 Edouard can you please take a look at this?

Comment 1

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
This is primary UI that is supposed to reliably indicate to the user whether or not they're signed in to fxa.

Comment 2

[Vijay Budhram]

Attachment: Bug 1564877 - Fix fxa avatar not clearing on sign out

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1edf0457ac23
Fix fxa avatar not clearing on sign out r=eoger

Comment 5

[Ryan VanderMeulen (PTO, back July 27)]

For future reference, checkin-needed is normally a bug keyword, not something added to the whiteboard. That'll allow Pulsebot to automatically clear it too :)

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1edf0457ac23

Comment 7

[Ryan VanderMeulen (PTO, back July 27)]

Please nominate this for Beta approval when you get a chance. Also, let's have QA verify this fix.

Comment 8

[ovidiu boca[:Ovidiu]]

I tested this on Mac OS X 10.14 and Windows 10 with FF Nightly 70.0a1 (2019-07-11) and I can confirm the fix.

Comment 9

[ovidiu boca[:Ovidiu]]

I will NI? myself to verify this after is uplifted.

Comment 10

[Vijay Budhram]

Attachment: avatar_picture_fix.patch

Beta/Release Uplift Approval Request

• User impact if declined: Fxa toolbar menu will show the user's avatar after they log out
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Sign into Firefox Account with a profile picture set, then log out.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change isn't risky because this error only occurs on log out and if a user set a custom avatar. Additionally, this patch only removes 1 css variable from the FxA avatar element when a log out event is detected.
• String changes made/needed:

Comment 11

[Ryan VanderMeulen (PTO, back July 27)]

Comment on attachment 9077108 [details]
Bug 1564877 - Fix fxa avatar not clearing on sign out

Fixes some FxA avatar issues. Approved for 69.0b5.

Comment 12

[Ryan VanderMeulen (PTO, back July 27)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0c8aee9afd1c

Comment 13

[ovidiu boca[:Ovidiu]]

I tested this on Mac OS X 10.14 and Windows 10 x64 with FF Beta 69.0b5 and I can confirm the fix.