Closed Bug 1564907 Opened 4 months ago Closed 4 months ago

Add AMD Navi GPU's to WebRender qualified device list

Categories

(Core :: Graphics: WebRender, task)

68 Branch
Desktop
Windows 10
task
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox-esr68 --- disabled
firefox67 --- wontfix
firefox68 --- wontfix
firefox69 --- fixed
firefox70 --- fixed

People

(Reporter: snecknico, Assigned: jrmuizel)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

According to a Reddit comment AMD Navi10 GPU's aren't on the WebRender qualified devices whitelist (confirmed by checking the qualified device list https://hg.mozilla.org/mozilla-central/file/tip/gfx/thebes/gfxPlatform.cpp#l2638 ).

Unsure of what the protocol is in adding new GPU's to said qualification list, does someone need to test and confirm the devices work with WebRender? Also unsure where to find the device ID's for said devices, otherwise I would've submitted a patch to add them.

We keep track of the device IDs here: https://github.com/jrmuizel/gpu-db. I've updated that to include NAVI10 and made a patch to add them to the white list.

Assignee: nobody → jmuizelaar
Blocks: wr-amd
Status: UNCONFIRMED → ASSIGNED
Type: -- → task
Ever confirmed: true
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/106de1ff387a
Add AMD Navi GPUs to WebRender qualified device list. r=aosmond
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Sounds like we definitely want to uplift this to Beta. I'm less sure about Release, though.

Flags: needinfo?(jmuizelaar)

We can uplift to beta. I don't think I'd want to uplift to release.

Flags: needinfo?(jmuizelaar)

Comment on attachment 9077105 [details]
Bug 1564907. Add AMD Navi GPUs to WebRender qualified device list.

Beta/Release Uplift Approval Request

  • User impact if declined: AMD users with new GPUs don't get WebRender
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky):
  • String changes made/needed:
Attachment #9077105 - Flags: approval-mozilla-beta?

Comment on attachment 9077105 [details]
Bug 1564907. Add AMD Navi GPUs to WebRender qualified device list.

Enables WebRender for newer AMD GPUs by default. Approved for 69.0b5.

Attachment #9077105 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Conflict while trying to uplift this patch on Beta on file: gfx/thebes/gfxPlatform.cpp

You need to log in before you can comment on or make changes to this bug.