Closed Bug 1564929 Opened 5 months ago Closed 5 months ago

Don't use app units in ComputeDefaultRenderRootRect

Categories

(Core :: Graphics: WebRender, task, P3)

Other Branch
task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file)

Spotted this while investigating something else. ComputeDefaultRenderRootRect converts a bunch of LayoutDevice things into app units with a fake app units conversion factor ("1") and then back into LayoutDevice. It seems like the only point of this is to be able to use nsRegion for region operations. But there's a perfectly good LayoutDeviceIntRegion that can be used instead. So we should do that.

Also move the impl to the .cpp file to avoid expensive rebuilds when it
is modified.

Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4720fc2b385e
Stop needless round-trip to fake app units. r=Gankro
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.