Closed Bug 1564947 Opened 1 year ago Closed 1 year ago

Make the WR display list dump friendly to document-splitting

Categories

(Core :: Graphics: WebRender, defect, P3)

Product:
Core
Component:
Graphics: WebRender
Version:
Other Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Bug 1564947 - Split the WR builder dump index into a RenderRootArray. r?Gankro
47 bytes, text/x-phabricator-request
Details | Review

Right now WebRenderCommandBuilder::mBuilderDumpIndex is a single index but is getting used to index into different display lists when document splitting is enabled. This results in the gfx.webrender.dl.dump* prefs producing a somewhat garbled output when enabled. The mBuilderDumpIndex needs to be turned into a RenderRootArray so that there is one per render root, and the index for a given render root should be used when indexing into the builder for that render root.

Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca567cce7c4e
Split the WR builder dump index into a RenderRootArray. r=Gankro

https://hg.mozilla.org/mozilla-central/rev/ca567cce7c4e

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.