1564965 - Port bug 1497211: Apply Meta CSP to about:support

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Richard Marti (:Paenglab)]

Bug 1497211 added a CSP header to the page.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1564965-meta-CSP-aboutSupport.patch

Port of https://hg.mozilla.org/mozilla-central/rev/4be4a2cb49bd

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9077153 [details] [diff] [review]
1564965-meta-CSP-aboutSupport.patch

Nice, have you tried it?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f975a8eb3c19
Port bug 1497211: Apply Meta CSP to about:support. r=jorgk

Comment 4

[Jorg K (CEST = GMT+2)]

Backout:
https://hg.mozilla.org/comm-central/rev/ba31676a4f3d301d291a08ac9398b02827a149b8

Sorry, I had to back this out since it's causing test failures which I confirmed with a local backout first. Aceman offered to look into this further.

Comment 5

[:aceman]

It's because that CSP line still does not allow all scripts:
Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”). support:173:17

It seems due to this the checkbox to reveal hidden data does not work in tests, which fail.

Comment 6

[:aceman]

Attachment: 1564965.patch

This works for me, converting some inline event handlers in element attributes to event listeners.
Try run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=8294fcc2ac8d5267ea8d076b59ef2b6ae72d7075

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9077476 [details] [diff] [review]
1564965.patch

Nice work.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/548774d8cc4a
Port bug 1497211: Apply Meta CSP to about:support. r=darktrojan

Comment 9

[Jorg K (CEST = GMT+2)]

Please make sure you change the author when picking up someone else's patch. For the record, this HG trick is useful:
hg commit --amend -u"newuser <[e-mail]>"

Comment 10

[Jorg K (CEST = GMT+2)]

Damn, I forgot the DONTBUILD option and since cancelling anything on the tree is broken, this will do a full build now :-(