Open Bug 1564980 Opened 3 years ago Updated 2 years ago

We seem to have no test for editor suppressing link handling.

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

People

(Reporter: emilio, Unassigned)

References

Details

I broke this in one of the patches that I uploaded to bug 1218456, and Olli caught it. It didn't cause any test to fail.

Depends on: 1218456

Emilio: can you please provide more information about how to reproduce this or perhaps provide a link to the patch/comment of Olli you're referring too?

Flags: needinfo?(emilio)

This is about: https://searchfox.org/mozilla-central/rev/f372470e10c8cb0691681603a1d6324dee5b3b8a/editor/libeditor/HTMLEditor.cpp#194

Apparently to trigger that codepath you need to call makeWindowEditable with aInteractive = false. The only caller in the tree for that is:

https://searchfox.org/mozilla-central/rev/f372470e10c8cb0691681603a1d6324dee5b3b8a/toolkit/content/widgets/editor.js#145

And it seems we have no <editor> in tree in mozilla-central, only in comm-central.

Flags: needinfo?(emilio)
Priority: -- → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.