1565027 - Teach `mach browsertime` to tell you to `mach browsertime --setup` if we're not already set up

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P3)

Description

[Markus Stange [:mstange]]

Steps to reproduce (not sure which ones of these are necessary to reproduce the issue):

1. I'm on macOS and have a copy of mach somewhere in my PATH.
2. In my mozilla-central source directory (at /Users/mstange/code/mozilla/) I have a file called .mozconfig-opt for a Firefox desktop build which places the objdir for that build next to the source dir (not inside the source dir)
3. Inside the objdir (at /Users/mstange/code/obj-m-opt/), I ran mach browsertime for the first time ever.
4. I watched it install its things.

And then the script failed because it couldn't find the file tools/browsertime/node_modules/browsertime/bin/browsertime.js.
And indeed, in my source dir, there is no node_modules directory inside tools/browsertime/.

Comment 1

[Markus Stange [:mstange]]

Attachment: full log

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Markus Stange [:mstange] from comment #0)

Steps to reproduce (not sure which ones of these are necessary to reproduce the issue):

1. I'm on macOS and have a copy of mach somewhere in my PATH.
2. In my mozilla-central source directory (at /Users/mstange/code/mozilla/) I have a file called .mozconfig-opt for a Firefox desktop build which places the objdir for that build next to the source dir (not inside the source dir)
3. Inside the objdir (at /Users/mstange/code/obj-m-opt/), I ran mach browsertime for the first time ever.

It will install some Python packages, but not the NPM modules. Run mach browsertime --setup (topsrcdir or topobjdir, should not matter). Witness $topsrcdir/tools/browsertime/node_modules being populated.

I'm going to morph this into "teach mach browsertime to tell you to set up when it's obvious you haven't".

Comment 3

[Markus Stange [:mstange]]

Hah, I see! Yes, such a message would help, especially for people like me who apparently just run random commands without reading the instructions... I think I wasn't expecting to have to run a manual setup command because similar mach commands, such as mach talos-test, don't require a manual setup invocation either.

Comment 4

[Tarek Ziadé (:tarek)]

Attachment: Bug 1565027 - check browsertime node install r=nalexander

Teach mach browsertime to tell you to mach browsertime --setup if we're not already set up

Comment 5

[Tarek Ziadé (:tarek)]

I am going to speed up the check by checking for the bt dir presence in the node modules, and spare the user an extra call to browsertime.js

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8692534449f
check browsertime node install

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d8692534449f