1565166 - Use events in WebSocketTransport instead of function hooks

Status: NEW

(Remote Protocol :: Agent, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

WebSocketTransport implement EventEmitter API, but most, but not all interactions (close event for example) with Connection class is done via the hooks constructor argument.
https://searchfox.org/mozilla-central/source/remote/server/WebSocketTransport.jsm#15-16

It would be easier to follow if WebSocketTransport would only emit events and Connection would only listen for events.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Note that this file is essentially a near-identical copy of
https://searchfox.org/mozilla-central/source/devtools/shared/transport/websocket-transport.js,
not that this prevents us from making more substantive changes to
it that suits us.