1565177 - TEST-UNEXPECTED-FAIL | comm/mail/components/enterprisepolicies/tests/browser/browser_policy_extensions.js | uncaught exception - ReferenceError: gListView is not defined at @chrome://messenger/content/aboutAddonsExtra.js:75:3

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

Mochitests (bct) are broken as of 2019-07-11, also linting errors saying about the same:
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mail/base/content/aboutAddonsExtra.js:75:3 | 'gListView' is not defined. (no-undef)

Comment 1

[Jorg K (CEST = GMT+2)]

Looks like this is from:
Andrew Swan - Bug 1563062 Part 2: Remove unused bits of old about:addons r=mstriemer
https://hg.mozilla.org/mozilla-central/rev/4fb3655540652629dffdbe4c93f43f3d982f5fe2#l3.1445

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1565177-temporarily-disable.diff

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9077351 [details] [diff] [review]
1565177-temporarily-disable.diff

This just disables our about:addons bits and updates our copy of the test.

Comment 4

[Geoff Lankow (:darktrojan)]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&group_state=expanded&revision=6183476b40cf2188be3c63adc227b3f5bd6f043f

That X3 is probably about to appear on comm-central too. I can't see it being related to this bug.

Comment 5

[Jorg K (CEST = GMT+2)]

Hmm, but it wasn't on the latest trunk run, so where did it come from?

Comment 6

[Jorg K (CEST = GMT+2)]

Hmm again. The test fails intermittently as treeherder suggests. It doesn't fail locally with or without the patch here.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9077351 [details] [diff] [review]
1565177-temporarily-disable.diff

I'm not really the right reviewer here, no idea what's going on with losing the quotes, etc. I'll land this in a while, you can find an additional reviewer who's more competent if you like.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cfbd315d507e
Temporarily remove Thunderbird additions to about:addons, and update a broken test. rs=bustage-fix,jorgk

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 9077351 [details] [diff] [review]
1565177-temporarily-disable.diff

rs=jorgk

Comment 10

[Richard Marti (:Paenglab)]

We could also set the pref extensions.htmlaboutaddons.recommendations.enabled to false. Then the empty "Recommended Extensions/Themes" below the extensions would be no more shown.

Comment 11

[Geoff Lankow (:darktrojan)]

(In reply to Jorg K (GMT+2) from comment #7)

no idea what's going on with losing the quotes, etc.

You mean this? That's because mozilla-central has run Prettier since we copied the file from there.

-    "policies": {
-      "Extensions": {
-        "Uninstall": [
-          addonID,
-        ],
-        "Install": [
-          `${BASE_URL}/policytest_v0.2.xpi`,
-        ],
+    policies: {
+      Extensions: {
+        Uninstall: [ADDON_ID],
+        Install: [`${BASE_URL}/policytest_v0.2.xpi`],

Comment 12

[Geoff Lankow (:darktrojan)]

Though this is a temporary fix, we already have bug 1565180 to reinstate it, so I'm closing this.