1565235 - Remove flushApzRepaints hack from inline options browser

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Mark Striemer [:mstriemer]]

We needed to call windowUtils.flushApzRepaints() to fix an issue with the inline browser. That has since been fixed in bug 1548687 and the workaround [1] can now be removed.

[1] https://searchfox.org/mozilla-central/search?q=Bug+1548687&path=

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1565235 - Remove flushApzRepaints() hack from about:addons inline options r?rpl

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67ed349b3786
Remove flushApzRepaints() hack from about:addons inline options r=rpl

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/67ed349b3786

Comment 4

[Miruna Curtean]

Hello,
Are there any particular scenarios that require verification after the removal of these hacks? Please provide some more context and steps in order for QA to manually verify if so. If that is not necessary please employ the "qe- verify" tag.
Thank you.

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi Miruna,
you should be able to verify that the behavior is now still fixed without the workaround by using a subset of the steps (the ones from 3 to 7) from the STR Mark provided in Bug 1548687 comment 0.

Comment 6

[Miruna Curtean]

Great. Thank you.
Verified on FF Nightly 74.0a1 (20200204214324) and 75.0a1 (20200212093201) on Windows Pro 10 64-bit and MacOS Catalina 10.15.
Installed Tree Style Tab extension and from it's Options/Preferences Context menu section I've checked/ unchecked the context menu items
and additional check boxes. Clicking on a checkbox highlights it until clicking outside it and adds a checkmark in the selected box.
Also tested to see if modifications remained saved after existing/entering the extension Options menu or after browser restart.