1565271 - Limit default view of description on expanded card

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P3)

Description

[Amy Tsay [:amyt]]

If an extension has a lot of text in its description, the expanded view currently displays all of it by default, bumping management settings all the way down the page. Consider limiting how much of the description is shown by default, with a link to Show More that expands the description inline.

Comment 1

[emanuela [ux]]

Attachment: scroll-section.png

Here an example on how the link can look like.

Comment 2

[aarushivij]

Hey Mark,
Can I work on it :)
Thanks
Aarushi

Comment 3

[Mark Striemer [:mstriemer]]

Yes, you can work on this. Comment 3 has the screenshot of how it should look.

Comment 4

[aarushivij]

Thanks
Shall start working on it :)
Aarushi

Comment 5

[Marinella]

(In reply to aarushivij from comment #4)

Thanks
Shall start working on it :)
Aarushi

Hi aarushivij, I was just about to work on bug 1599297, I'm waiting for that you submit your change :)

Comment 6

[aarushivij]

Hey Marinella, I was am working on the bug, I think I will come up with the patch soon :)
Aarushi

Comment 7

[Maverick]

Any ETA for this feature?

Or is it blocked by something else :) ?

Comment 8

[Anshuman Singh]

Is it a beginner friendly bug ? If yes, then i would like to work on this one.from where do i begin? Please guide me.

Comment 9

[Dmitrij Feller]

Attachment: Bug 1565271 - Limit default view of description on expanded card.r?mstriemer

Comment 10

[Dmitrij Feller]

Attachment: WIP: Bug 1565271 - Refactor rendering of the details into its own function.

Depends on D145174

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a76fb5e29da
Limit default view of description on expanded card.r=mstriemer,fluent-reviewers

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4a76fb5e29da

Comment 13

[Maverick]

Does this fix eliminates the need to scroll on the addon's page?

Or does the request in bug 1599297 still makes sense?

Comment 14

[Dmitrij Feller]

Bug 1599297 is still relevant. This fix just adds a collapsed view of too long detail descriptions with a "Show more" button at the end. So, after a user clicks on the "Show more" button, the view will extend, and depending on the length of the detail description, considerable scrolling might be required. This is where Bug 1599297 comes into play.

Comment 15

[Maverick]

(In reply to Dmitrij Feller from comment #14)

Bug 1599297 is still relevant. ... This is where Bug 1599297 comes into play.

Agreed. :) I submitted 1599297 but was unsure if i should close it or not now. I'll leave it open then :)