1565320 - Bookmark with invalid URL prevents any bookmarks from syncing

Status: RESOLVED INCOMPLETE

(Firefox :: Sync, defect, P3)

Description

[grisailleux]

Attachment: error-sync-1562777591286.txt

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Try to sync with other devices from my PC (Windows 10 Pro 1803 17134.829)

Actual results:

Nothing.

Expected results:

Sync.

Comment 1

[[:philipp]]

hi, the log shows that there's one malformed bookmark causing sync to trip ("http://www.kasmail%20.com/"). can you try to delete it and see if things improve?

Comment 2

[grisailleux]

Hi
Thank you for your answer.
I have tried but I cannot delete this bookmark. I have also tried to delete all of the bookmarks, but the malformed one blocks this operation.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Thanks for the report. Mak, it seems wrong that a bookmark with an invalid URL can't be deleted by the library, but I can't find a bug on file for that - should I open one?

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Bug 1401401 should have fixed that problem in Firefox 69.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:markh, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 7

[Ryan Kelly [:rfkelly]]

This bug has an 11-month-old needinfo? for :lina, but reading back over it, it's not entirely clear to me what info she is supposed to provide.

:grisailleux, if you're still following along here after a year, can you confirm whether you were ever able to remove this invalid bookmark and get sync working correctly again?

Comment 8

[Lina Butler [:lina]]

Yikes, I'm so sorry for letting this slide! I think the ni? was to make sure the new Rust engine could handle invalid URLs, which we added as part of bug 1482608 and bug 1615931, and have enabled everywhere since 70. If a bookmark has an invalid URL, either in Places or from the server, we'll try to replace it with a valid one from the other side, or delete it outright if we can't. Please let us know if you're still seeing issues!

Comment 9

[Ryan Kelly [:rfkelly]]

Since we're unable to confirm whether the issue still persists, I'm going to close this bug.