Closed Bug 1565370 Opened 5 years ago Closed 5 years ago

Intermittent <test> | A promise chain failed to handle a rejection: [Exception... "Component not initialized" nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)" location: "JS frame :: resource://gre/modules/remotepagemanager/MessagePort.jsm :: sendAsyncMes

Categories

(Firefox :: Protections UI, defect, P5)

Product:
Firefox
Component:
Protections UI
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: ewright)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [test isolation][protection-report][triage][stockwell disable-recommended])

Attachments

(1 file)

Bug 1565370 - Fix intermittent caused by async messaging.
47 bytes, text/x-phabricator-request
Details | Review

Filed by: rgurzau [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=256008622&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/MMFJ4oLGSo6MK6xQYv56IQ/runs/0/artifacts/public/logs/live_backing.log

19:44:18 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | The mini panel hides automatically. -
19:44:18 INFO - Buffered messages finished
19:44:18 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteProtections/browser_protections_UI.js | A promise chain failed to handle a rejection: [Exception... "Component not initialized" nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)" location: "JS frame :: resource://gre/modules/remotepagemanager/MessagePort.jsm :: sendAsyncMessage :: line 336" data: no] - stack: sendAsyncMessage@resource://gre/modules/remotepagemanager/MessagePort.jsm:336:25
19:44:18 INFO - receiveMessage/<@resource:///modules/aboutpages/AboutProtectionsHandler.jsm:81:29
19:44:18 INFO - Rejection date: Thu Jul 11 2019 19:44:17 GMT+0000 (Greenwich Mean Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 263
19:44:18 INFO - Stack trace:
19:44:18 INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:263
19:44:18 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1377
19:44:18 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1381
19:44:18 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1209
19:44:18 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
19:44:18 INFO - Leaving test bound testMiniPanel
19:44:18 INFO - Entering test bound testToggleSwitchFlow
19:44:19 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | The protections popup should have the 'toast' attribute. -
19:44:19 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | The 'toast' attribute should be cleared on the protections popup. -
19:44:20 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | The protections popup should have the 'toast' attribute. -
19:44:20 INFO - Leaving test bound testToggleSwitchFlow
19:44:20 INFO - GECKO(5360) | MEMORY STAT | vsize 855MB | vsizeMaxContiguous 683MB | residentFast 303MB | heapAllocated 130MB
19:44:20 INFO - TEST-OK | browser/base/content/test/siteProtections/browser_protections_UI.js | took 6330ms
19:44:20 INFO - checking window state

Type: -- → defect
Component: General → Tracking Protection
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Whiteboard: [test isolation]
Summary: Intermittent browser/base/content/test/siteProtections/browser_protections_UI.js | A promise chain failed to handle a rejection: [Exception... "Component not initialized" nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)" → Intermittent <test> | A promise chain failed to handle a rejection: [Exception... "Component not initialized" nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)" location: "JS frame :: resource://gre/modules/remotepagemanager/MessagePort.jsm :: sendAsyncMes
Whiteboard: [test isolation] → [test isolation][protection-report][triage]

Erica, can you take a look at this, please? :)

Flags: needinfo?(ewright)

Joel, any suggestions here?

Flags: needinfo?(jmaher)

:apavel, is there a root cause identfied? it is a little late to backout, but we can identify the author of the root cause and see if a fix can happen, possibly backout if it makes sense.

Flags: needinfo?(jmaher) → needinfo?(apavel)

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #13)

:apavel, is there a root cause identfied? it is a little late to backout, but we can identify the author of the root cause and see if a fix can happen, possibly backout if it makes sense.

No, however Cosmin might be able to take a look at this tonight and find something. Redirecting ni to him.

Flags: needinfo?(apavel) → needinfo?(csabou)

This started with failures on browser/base/content/test/siteProtections/browser_protections_UI.js and went so till the 17th when it started failing almost all the time on browser_firstPartyIsolation_aboutPages.js.
It took me some time to work on this but I'm pretty sure the culprit is Bug 1557061 https://hg.mozilla.org/integration/autoland/rev/78bbc78267bdf567920e290bb1b6320adab60bde
Retriggers: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=os%2Cx%2C10.10%2Cdebug%2Cmochitests%2Ctest-macosx1010-64%2Fdebug-mochitest-browser-chrome-e10s-9%2Cm%28bc9%29&fromchange=8b94f563baf130f850e1aa090a5082009c60767b&tochange=89da8a8fed0d19bfe2846d3f024c219d4d3e16ce&selectedJob=258423439
Erica was ni'ed in comment 9. A backout of 1557061 doesn't apply cleanly so a patch here would be most welcomed.

Flags: needinfo?(csabou)
Regressed by: 1557061

(In reply to Cosmin Sabou [:CosminS] from comment #15)

This started with failures on browser/base/content/test/siteProtections/browser_protections_UI.js and went so till the 17th when it started failing almost all the time on browser_firstPartyIsolation_aboutPages.js.
It took me some time to work on this but I'm pretty sure the culprit is Bug 1557061 https://hg.mozilla.org/integration/autoland/rev/78bbc78267bdf567920e290bb1b6320adab60bde
Retriggers: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=os%2Cx%2C10.10%2Cdebug%2Cmochitests%2Ctest-macosx1010-64%2Fdebug-mochitest-browser-chrome-e10s-9%2Cm%28bc9%29&fromchange=8b94f563baf130f850e1aa090a5082009c60767b&tochange=89da8a8fed0d19bfe2846d3f024c219d4d3e16ce&selectedJob=258423439
Erica was ni'ed in comment 9. A backout of 1557061 doesn't apply cleanly so a patch here would be most welcomed.

I can remove the parts of the tests that are failing, I'd prefer to fix the failure, but that might have to wait until after the softfreeze for 70 to prioritize the new development.
The issue is with sendAsyncMessage, in aboutProtectionsHandler.jsm by the time the message sends the tab has already been closed. We tried to fix this issue earlier by checking first if the browser was still there before kicking off the send, and it fixed most of the failures, but perhaps the browser closes just before sending in these cases.

Flags: needinfo?(ewright)
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/868d164e8272
Fix intermittent caused by async messaging. r=johannh

https://hg.mozilla.org/mozilla-central/rev/868d164e8272

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Assignee: nobody → ewright

Looks like this intermittent is still happening? The fix only just landed, so I'm going to wait a few more days before looking again.

Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: