Closed Bug 1565406 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 17795 - Delete test_valid_but_unmatchable_key webdriver test

Categories

(Testing :: geckodriver, task, P4)

task

Tracking

(firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 17795 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17795
Details from upstream follow.

Julian Kung <juliankung@chromium.org> wrote:

Delete test_valid_but_unmatchable_key webdriver test

This test is designed with the assumption that the first set of capabilities should be rejected during the matching capabilities algorithm at step 3 when following the "otherwise" substep due to the extension capability "foo:unmatchable".

If name is the key of an extension capability, let value be the result of trying implementation-specific steps to match on name with value. If the match is not successful, return success with data null.

However, the test incorrectly assumes that the implementation-specific steps will result in an unsuccessful match. The test therefore is no longer strictly adhering to the defined spec.

No browsers are currently passing this tests so I propose that it should be removed.

Component: web-platform-tests → geckodriver
Type: -- → task
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
PASS: 5
FAIL: 2

Chrome

OK : 1
PASS: 6
FAIL: 1

Safari

OK : 1
PASS: 4
FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webdriver/tests/new_session/default_values.py
test_no_capabilites: FAIL (Chrome: PASS, Safari: FAIL)
test_desired: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9484ca736521
[wpt PR 17795] - Delete test_valid_but_unmatchable_key webdriver test, a=testonly
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.