1565464 - Accept any iterable for parameterDescriptors in AudioWorkletGlobalScope.registerProcessor()

Status: RESOLVED FIXED

(Core :: Web Audio, enhancement, P3)

Comment 1

[Karl Tomlinson (:karlt)]

https://github.com/WebAudio/web-audio-api/issues/1947

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1565464 - Accept any iterable for parameterDescriptors in AudioWorkletGlobalScope.registerProcessor(). r?karlt

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1565464 - Add a WPT to check that various iterable work to specify AudioParam descriptors in AudioWorkletProcessor definition. r?karlt

Comment 4

[Paul Adenot (:padenot)]

Relevant: https://github.com/WebAudio/web-audio-api/issues/2171
https://github.com/WebAudio/web-audio-api/pull/2172

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1565464 - Allow not having a parameterDescriptor getter in an AudioWorkletProcessor. r?karlt

https://github.com/WebAudio/web-audio-api/issues/2171

Comment 6

[Paul Adenot (:padenot)]

Attachment: Bug 1565464 - Explicitly test in WPT that AudioWorkletProcessor can have no parameterDescriptor getters. r?karlt

This was implicitely tested before, but has its place in this new test.

Comment 7

[Paul Adenot (:padenot)]

Attachment: Bug 1565464 - Expect WPT failures for AudioParamDescriptor tests related to automationRate. r?karlt

Comment 8

[Paul Adenot (:padenot)]

Attachment: Bug 1565464 - Add a WPT to check that having two parameters with the same name in parameterDescriptors throws. r?karlt

Comment 9

[Paul Adenot (:padenot)]

Attachment: Bug 1565464 - Accept any iterable for parameterDescriptors in AudioWorkletGlobalScope.registerProcessor(). r?karlt

Comment 10

[Paul Adenot (:padenot)]

Attachment: Bug 1565464 - Update test_audioWorkletGlobalScopeRegisterProcessor.html with new error messages and error type. r?karlt

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a42d320c192c
Accept any iterable for parameterDescriptors in AudioWorkletGlobalScope.registerProcessor(). r=karlt
https://hg.mozilla.org/integration/autoland/rev/1c13ea72af53
Add a WPT to check that various iterable work to specify AudioParam descriptors in AudioWorkletProcessor definition. r=karlt
https://hg.mozilla.org/integration/autoland/rev/c1e0df633ac8
Allow not having a parameterDescriptor getter in an AudioWorkletProcessor. r=karlt
https://hg.mozilla.org/integration/autoland/rev/20e21af0f1e1
Explicitly test in WPT that AudioWorkletProcessor can have no parameterDescriptor getters. r=karlt
https://hg.mozilla.org/integration/autoland/rev/d3267e8893ba
Expect WPT failures for AudioParamDescriptor tests related to automationRate. r=karlt
https://hg.mozilla.org/integration/autoland/rev/af901d3bf5a5
Add a WPT to check that having two parameters with the same name in parameterDescriptors throws. r=karlt
https://hg.mozilla.org/integration/autoland/rev/e96390a0bb9a
Update test_audioWorkletGlobalScopeRegisterProcessor.html with new error messages and error type. r=karlt

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/22490 for changes under testing/web-platform/tests

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 14

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a42d320c192c
https://hg.mozilla.org/mozilla-central/rev/1c13ea72af53
https://hg.mozilla.org/mozilla-central/rev/c1e0df633ac8
https://hg.mozilla.org/mozilla-central/rev/20e21af0f1e1
https://hg.mozilla.org/mozilla-central/rev/d3267e8893ba
https://hg.mozilla.org/mozilla-central/rev/af901d3bf5a5
https://hg.mozilla.org/mozilla-central/rev/e96390a0bb9a

Comment 15

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot