1565480 - Add pagination at the top of the alerts page

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement, P1)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

The pagination is currently only at the bottom.

Comment 1

[Ionuț Goldan [:igoldan]]

(In reply to Alexandru Ionescu :alexandrui from comment #0)

The pagination is currently only at the bottom.

Are you all ok with this?

Comment 2

[Florin Strugariu [:Bebe]]

As the page can get quite big I think this is a good idea.

Comment 3

[Marian Raiciof [:marauder]]

+1 for Florin's comment #c2

Comment 4

[Suresh N]

I'm Interested in solving this, Can you assign it to me.

Comment 5

[Ionuț Goldan [:igoldan]]

(In reply to Suresh N from comment #4)

I'm Interested in solving this, Can you assign it to me.

Hi, Suresh! Are you still interested in working on this ticket?

Comment 6

[stwtdey1]

(In reply to Ionuț Goldan [:igoldan] from comment #5)

(In reply to Suresh N from comment #4)

I'm Interested in solving this, Can you assign it to me.

Hi, Suresh! Are you still interested in working on this ticket?

If no one is currently working on this, I would gladly take it up!

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5863

Comment 8

[Suyash Salampuria]

Thanks for assigning it to me sarah:)
I will follow the process from next time fo sure

Comment 9

[Alexandru Ionescu (needinfo me) [:alexandrui]]

One thing I noticed just now: when navigation to another status/framework from a page > 1 the url param &page= won't update to 1.

Comment 10

[Suyash Salampuria]

I just looked into this problem
This problem exists because validated.page remains as it does change while changing the dropdowns and it exists from before this PR was made
I think that we should file another bug for this.
Shall I go on for doing this

Comment 11

[Ionuț Goldan [:igoldan]]

(In reply to suyash546 from comment #10)

I just looked into this problem
This problem exists because validated.page remains as it does change while changing the dropdowns and it exists from before this PR was made
I think that we should file another bug for this.
Shall I go on for doing this

+1 for treating this in a separate bug.
But 1st: Alex, please provide a comment here with the exact steps to reproduce.

Comment 12

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to suyash546 from comment #10)

I just looked into this problem
This problem exists because validated.page remains as it does change while changing the dropdowns and it exists from before this PR was made
I think that we should file another bug for this.
Shall I go on for doing this

Yes, this is not a regression, I initially thought that this PR fixed the issue. Actually it partially fixed it. Before this, when navigating from a status/framework filter page greater than 1 (say 4) to a filter that doesn't have the current number of pages (less than 4) the UI was returning an error. Now it's correctly directing to page 1, but without updating the URL.
Steps to reproduce here: https://mozilla.zoom.us/rec/play/vpB-JLyvrDg3GIWW5ASDAP4oW9XoKvms2iAcrKcOxUm0AHdXZ1OjM7BBNup7ew04f9MGdT_3bg1bIK8X?continueMode=true

Comment 13

[Suyash Salampuria]

Shall I try opening this Bug (first time on Bugzilla :) )

Comment 14

[Ionuț Goldan [:igoldan]]

(In reply to suyash546 from comment #13)

Shall I try opening this Bug (first time on Bugzilla :) )

Sure you can.