1565486 - 1.83 - 2.34% raptor-sunspider-firefox (linux64-shippable-qr) regression on push ec4aac5a6c9f6b0172894a44bed7ad3393bfbae0 (Mon June 24 2019)

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect, P1)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Raptor has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=ec4aac5a6c9f6b0172894a44bed7ad3393bfbae0

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

2% raptor-sunspider-firefox linux64-shippable-qr opt 213.24 -> 218.23
2% raptor-sunspider-firefox linux64-shippable-qr opt 213.50 -> 217.40
3% raptor-stylebench-firefox windows10-64-shippable opt 44.40 -> 45.58

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=21841

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a Treeherder page showing the Raptor jobs in a pushlog format.

To learn more about the regressing test(s) or reproducing them, please see: https://wiki.mozilla.org/Performance_sheriffing/Raptor

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Performance_sheriffing/Talos/RegressionBugsHandling

Comment 1

[Jon Coppeard (:jonco)]

This change also got us the following improvement (see bug 1557771):

3% raptor-stylebench-firefox windows10-64-shippable opt 44.40 -> 45.58

Someone needs to make the call whether one is worth the other. I'm happy for this to be backed out if that's what we decide.

Comment 2

[Alexandru Ionescu (needinfo me) [:alexandrui]]

There's also the regression below related:
== Change summary for alert #21584 (as of Tue, 25 Jun 2019 13:00:35 GMT) ==

Regressions:

7% raptor-assorted-dom-firefox linux64-shippable-qr opt 26.71 -> 28.69
6% raptor-assorted-dom-firefox linux64-shippable opt 26.93 -> 28.47
5% raptor-assorted-dom-firefox linux64-shippable opt 27.13 -> 28.45

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=21584

Comment 3

[Jon Coppeard (:jonco)]

I'll back out in bug 1557771.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jonco, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Jon Coppeard (:jonco)]

The regressing change has been backed out.