The default system theme is not automatically enabled when an installed theme is Removed
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Tracking
()
People
(Reporter: LexaSV, Assigned: robwu)
References
Details
Attachments
(3 files, 1 obsolete file)
769.20 KB,
image/gif
|
Details | |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
863.65 KB,
image/gif
|
Details |
[Tested platforms]
- Win10x64
- macOS High Sierra 10.13.6
[Steps to reproduce]
- Open about:addons
- Install one of the Recommended themes (or a theme from AMO)
- Remove the theme
- Observe the status of the Default system theme
[Expected result]
The default system theme is automatically re-enabled when an installed theme is Removed
[Actual result]
The default system theme remains disabled when a theme is Removed
Notes:
- if you Disable the installed theme before Removing it, the issue will not reproduce
- the issue becomes even more visible when a dark system theme is set on the user's machine - in this case the header will receive a dark gray color
- restarting the browser doesn't fix the issue
Comment 1•2 years ago
|
||
The old about:addons was faking the pending uninstall for themes by disabling them [1] and setting the pending="uninstall"
attribute. We could do something similar here, or stop doing pending uninstalls for themes (we'll likely remove it for extensions too, but maybe best to do that together).
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
Assignee | ||
Comment 4•2 years ago
|
||
Updated•2 years ago
|
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/f665f6ac47a9 Enable default theme on theme uninstallation r=aswan
Comment 6•2 years ago
|
||
bugherder |
Comment 7•2 years ago
|
||
Rob, would that be a safe patch to uplift to beta? If you feel this is a good candidate, please propose it for uplifting to 69, thanks.
Assignee | ||
Comment 8•2 years ago
|
||
Comment on attachment 9080675 [details]
Bug 1565507 - Enable default theme on theme uninstallation
Beta/Release Uplift Approval Request
- User impact if declined: When a theme is uninstalled, the default theme is not re-enabled (the Themes list only shows "Disabled" themes, none of them are "Enabled").
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The patch includes multiple unit tests. One test for the about:addons UI, and more unit tests to verify the behavior of the internals.
- String changes made/needed: none
Reporter | ||
Comment 9•2 years ago
|
||
Verified fixed in latest Nightly with Win10x64 and macOS High Sierra 10.13.6
Reporter | ||
Comment 10•2 years ago
|
||
Updated•2 years ago
|
Comment 11•2 years ago
|
||
Comment on attachment 9080675 [details]
Bug 1565507 - Enable default theme on theme uninstallation
Approved for 69.0b13. Thanks for including new tests for this.
![]() |
||
Comment 12•2 years ago
|
||
bugherderuplift |
Reporter | ||
Comment 13•2 years ago
|
||
This is also verified fixed in 69.0b13.
Reporter | ||
Updated•2 years ago
|
Description
•