1565507 - The default system theme is not automatically enabled when an installed theme is Removed

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Alexandra Moga [:LexaSV]]

Attachment: disabled default system theme.gif

[Tested platforms]

• Win10x64
• macOS High Sierra 10.13.6

[Steps to reproduce]

1. Open about:addons
2. Install one of the Recommended themes (or a theme from AMO)
3. Remove the theme
4. Observe the status of the Default system theme

[Expected result]
The default system theme is automatically re-enabled when an installed theme is Removed

[Actual result]
The default system theme remains disabled when a theme is Removed

Notes:

• if you Disable the installed theme before Removing it, the issue will not reproduce
• the issue becomes even more visible when a dark system theme is set on the user's machine - in this case the header will receive a dark gray color
• restarting the browser doesn't fix the issue

Comment 1

[Mark Striemer [:mstriemer]]

The old about:addons was faking the pending uninstall for themes by disabling them [1] and setting the pending="uninstall" attribute. We could do something similar here, or stop doing pending uninstalls for themes (we'll likely remove it for extensions too, but maybe best to do that together).

[1] https://searchfox.org/mozilla-central/rev/cbde79674f616a1c6e71dd4d15a09789cdfaa391/toolkit/mozapps/extensions/content/extensions.xml#1265-1272

Comment 3

[Rob Wu [:robwu]]

Attachment: Bug 1565507 - Enable default theme on theme uninstallation

Comment 4

[Rob Wu [:robwu]]

Attachment: Bug 1565507 - Re-enable theme when uninstall is undone

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f665f6ac47a9
Enable default theme on theme uninstallation r=aswan

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/f665f6ac47a9

Comment 7

[Pascal Chevrel:pascalc]

Rob, would that be a safe patch to uplift to beta? If you feel this is a good candidate, please propose it for uplifting to 69, thanks.

Comment 8

[Rob Wu [:robwu]]

Comment on attachment 9080675 [details]
Bug 1565507 - Enable default theme on theme uninstallation

Beta/Release Uplift Approval Request

• User impact if declined: When a theme is uninstalled, the default theme is not re-enabled (the Themes list only shows "Disabled" themes, none of them are "Enabled").
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch includes multiple unit tests. One test for the about:addons UI, and more unit tests to verify the behavior of the internals.
• String changes made/needed: none

Comment 9

[Alexandra Moga [:LexaSV]]

Verified fixed in latest Nightly with Win10x64 and macOS High Sierra 10.13.6

Comment 10

[Alexandra Moga [:LexaSV]]

Attachment: postfix.gif

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9080675 [details]
Bug 1565507 - Enable default theme on theme uninstallation

Approved for 69.0b13. Thanks for including new tests for this.

Comment 12

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a6ce868f8d1c

Comment 13

[Alexandra Moga [:LexaSV]]

This is also verified fixed in 69.0b13.