Closed Bug 1565531 Opened 5 months ago Closed 3 months ago

Step over in async code doesn't work right

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: Gijs, Unassigned)

References

(Blocks 1 open bug)

Details

What were you doing?

  1. have some passwords saved in Chrome (don't have to be real ones; see also bug 1557960)
  2. Open Firefox
  3. Open the logins pane (Hamburger > logins and passwords)
  4. Open the importer
  5. Open the browser debugger
  6. set a breakpoint in the migrate function at https://searchfox.org/mozilla-central/rev/15be167a5b436b57fef944b84eef061d24c1af8c/browser/components/migration/ChromeProfileMigrator.jsm#436 , on the await statement near the top that gets the password rows from Chrome's sqlite DB
  7. go through the import wizard and choose to import only passwords from Chrome
  8. watch the breakpoint get hit
  9. press 'step over'

What happened?

You end up in MigrationUtils somehow. If you keep stepping, eventually the debugger gets even more confused and doesn't seem to know where you're stopped anymore.

What should have happened?

Step to the next line in the function.

Blocks: dbg-control
Priority: -- → P2

Gijs, could you try this again? We landed proper async stepping in july.

Flags: needinfo?(gijskruitbosch+bugs)

This seems to work now, thanks!

Status: NEW → RESOLVED
Closed: 3 months ago
Flags: needinfo?(gijskruitbosch+bugs)
Resolution: --- → WORKSFORME

Great!

You need to log in before you can comment on or make changes to this bug.