Open Bug 1565545 Opened 6 years ago Updated 2 years ago

Fix webextension native messaging and other tests that use parent-process content loads

Categories

(WebExtensions :: General, task, P3)

task

Tracking

(Not tracked)

People

(Reporter: Gijs, Unassigned)

References

Details

See https://hg.mozilla.org/integration/autoland/rev/45fca0f1b675 . Basically, this bug is about fixing the tests that require pref flips "properly".

I think some of the ones where I flipped prefs can easily just pass {remote: true} as an argument to loadContentPage ( https://searchfox.org/mozilla-central/rev/15be167a5b436b57fef944b84eef061d24c1af8c/toolkit/components/extensions/ExtensionXPCShellUtils.jsm#977 ), or otherwise ensure that they load content in the child, but I didn't want to mess too much with tests that I didn't write at this point, in case there was a reason they weren't testing things that way.

I'll also note that the tests in the native messaging xpcshell manifest still use non-remote webextensions, and should probably be run with remote webextensions instead. Given fennec is dead on trunk now, it's unclear to me if running any tests without remote webextensions is really helpful at this point, but I'll leave that decision for someone else to make...

(In reply to :Gijs (he/him) from comment #0)

Given fennec is dead on trunk now, it's unclear to me if running any tests without remote webextensions is really helpful at this point, but I'll leave that decision for someone else to make...

As far as I'm aware, we still aren't allowed to break Fennec on trunk, and until there's an announcement that we are, I'm reluctant to do so.

In any case, Fenix still uses non-remote extensions for the time being.

Priority: -- → P3
See Also: → 1568013

The bulk of this is in patches in bug 1644287

Depends on: 1644287
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.