Closed Bug 1565556 Opened 5 months ago Closed 5 months ago

More cleanups in SharedScriptData

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

There are small inconsistencies and comments to fix as follow-up to SharedScriptData changes.

As well, this will be renamed to ImmutableScriptData since RuntimeScriptData/SharedScriptData is a bit confusing.

Add an 'Offset' type-alias to better document as well as fixing up
out-of-date comments. This also moves the optArrayOffset to beginning of
structure.

After this patch a JSScript will have Private, Runtime, and Immutable
script data type attached to it.

Depends on D37866

With the current design of ImmutableScriptData, even empty arrays have a
legal span so we no longer need to change the hasTryNotes and friends
helpers. In most cases we were performing a range-for afterwards so this
has simpler semantics.

Keywords: leave-open
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6e96caa9f2d
Cleanup SharedScriptData optional arrays. r=jandem
https://hg.mozilla.org/integration/autoland/rev/9056a9e2cf4a
Rename SharedScriptData to ImmutableScriptData. r=jandem
Keywords: leave-open
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/552b13ce8016
Remove JSScript::hasTryNotes/ScopeNotes/ResumeOffsets. r=jandem
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Depends on: 1576303
No longer depends on: 1576303
You need to log in before you can comment on or make changes to this bug.