Closed Bug 1565634 Opened 1 year ago Closed 4 months ago

Have `mach install` install GeckoView Example

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

enhancement
Not set

Tracking

(firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: botond, Assigned: m_kato)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

./mach gradle geckoview_example:installWithGeckoBinariesDebug is a lot to type.

Could we have something like ./mach install --app=gve? While ./mach install --app=fennec installs Fennec? (And eventually, the default should probably change.)

./mach android install-geckoview_example exists today which is a bit easier to remember. Not quite as easy as ./mach install though

I've been thinking of ./mach install ... myself. I'm happy with --app=org.mozilla.geckoview_example, perhaps with fuzzy matching so that --app=gve would work.

Product: Firefox for Android → Firefox Build System

Now that Fennec is no longer a thing, we should just have ./mach install install GVE.

Summary: Add a shorter mach command for installing GeckoView Example → Have `mach install` install GeckoView Example

Fennec is removed, but mach install still tries to install Fennec. It should
install GVE instead.

I don't mind GVE as a default, but remember that mochitests, reftests, wpt, etc all run against org.mozilla.geckoview.test; it would be nice to have a simple install command for that too.

(In reply to Geoff Brown [:gbrown] from comment #5)

I don't mind GVE as a default, but remember that mochitests, reftests, wpt, etc all run against org.mozilla.geckoview.test; it would be nice to have a simple install command for that too.

Fair point. Makato-san's patch would accept ./mach install --app org.mozilla.geckoview.test: good enough?

Flags: needinfo?(gbrown)

Certainly!

Flags: needinfo?(gbrown)
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/e527a2e55bad
mach install should install GVE as default. r=nalexander
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Assignee: nobody → m_kato
You need to log in before you can comment on or make changes to this bug.