Closed Bug 1565688 Opened 5 months ago Closed 5 months ago

Remove unused IOService arg from NS_NewURI

Categories

(Core :: Networking, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Seems to be unused after bug 1536744.

Jorg, NS_NewMailnewsURI will need to remove it too, but that doesn't use the arg either, right?

Depends on: 1536744
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5caa28e37f72
Remove unused IOService arg from NS_NewURI.  r=mayhemer
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1709d47903f5
C-C part: Remove unused IOService arg from NS_NewMailnewsURI. r=me

== Change summary for alert #21906 (as of Mon, 15 Jul 2019 21:50:15 GMT) ==

Improvements:

21% raptor-tp6-bing-firefox loadtime macosx1014-64-shippable opt 278.29 -> 220.29
20% raptor-tp6-bing-firefox macosx1014-64-shippable opt 284.86 -> 226.59
19% raptor-tp6-bing-firefox fcp macosx1014-64-shippable opt 305.45 -> 246.54

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=21906

That would be really surprising and worrying. This bug removed unused arguments that weren't even getting passed in most places; I would expect it to not have any performance impact. If it did, that suggests we have a behavior change somewhere that was not intended or something...

How sure are we that this patch corresponds to the performance change?

Flags: needinfo?(alexandru.ionescu)

I did some retriggers to confirm what the graph is currently showing.

Flags: needinfo?(alexandru.ionescu)

Fortunately, the retriggers reveal infra changes.

Thank you for verifying that!

You need to log in before you can comment on or make changes to this bug.