Closed Bug 1565702 Opened 2 months ago Closed 2 months ago

Issues with "Create New Login" form

Categories

(Toolkit :: Password Manager, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- disabled
firefox70 --- verified
firefox71 --- verified

People

(Reporter: ntim, Assigned: jaws)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [passwords:management] [skyline])

Attachments

(5 files)

Attached image image.png
  • "Save Changes" should use a different string, since we're creating a new login
  • That same button should be blue, not gray
  • The save button should have type="submit" and the "Cancel" button should have type="button"
  • The click event handler for the save button should move to be a submit event handler on the parent form
Keywords: access
Whiteboard: [passwords:management] [skyline]
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/975c468c465b
Save Changes button should use a different string for new logins. r=MattN,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/36f72c9d32a7
Hide the Copy buttons when in 'Create' mode. r=MattN
https://hg.mozilla.org/integration/autoland/rev/e42bb7951a0a
Use type=submit on the save-changes-button and type=button for the rest of the buttons in the form. r=MattN
https://hg.mozilla.org/integration/autoland/rev/32fde7fa9949
Move the event handler for the save-changes-button to the submit handler on the form instead of a click handler on the button itself. r=MattN
Flags: qe-verify+

I have verified this issue on the latest Nightly 71.0a1 (2019-09-16) (64-bit) on Windows 10, MacOS 10.14 and Ubuntu 16.04 x64.

  • "Save Changes" string was replaced with "Save" string on the "Create New Login" mode.
  • The background of the "Save" button is blue.
  • The "Save" button has type="Submit" and the "Cancel" button has type="button".
  • The login is correctly saved when click on the "Save" button.
You need to log in before you can comment on or make changes to this bug.