Closed Bug 1565717 Opened 4 months ago Closed 3 months ago

Remove MacIOSurfaceLib and link to the IOSurface framework directly

Categories

(Core :: Graphics, task)

All
macOS
task
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(5 files)

We have code in gfx/2d/MacIOSurface.cpp which manually gets functions from the IOSurface framework by calling dlsym. This was necessary a long time ago, but it's no longer necessary today: In macOS 10.6, the IOSurface framework was made public.

In bug 1565668 I'm adding "-framework IOSurface" to the moz.build in gfx/gl and calling some IOSurface functions directly.

We should migrate the users of MacIOSurfaceLib to the actual functions and remove MacIOSurfaceLib.

These were used for creating accelerated CGContexts that render to an IOSurface.
We only used those experimentally on Nightly for a while but turned that option
off because of crashes. And in the meantime, DrawTargetCG has been removed
entirely. So we'll probably never use these functions again.

These functions were made public in 10.6. The oldest version we support is 10.9.

Depends on D41812

Blocks: 1573668
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/69ae93abded3
Remove unused MacIOSurface functions. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/9072a9f04ddd
Don't use dynamic symbol lookup for CGLTexImageIOSurface2D. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/8dfadc1af721
Don't use dynamic symbol lookup for CVPixelBufferGetIOSurface. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/35ae2dc9438e
Remove dynamic lookup of the kIOSurface constants. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/6c4665fb2c10
Remove all dynamic loading of IOSurface functions. r=mattwoodrow
Assignee: nobody → mstange
You need to log in before you can comment on or make changes to this bug.