1565829 - "Error retrieving Push subscription." is too scarce of details

Status: NEW

(Core :: DOM: Push Subscriptions, enhancement, P5)

Description

[Marco Castelluccio [:marco]]

I have integration tests for the web-push library for Firefox Release, Beta and Nightly. Since a few weeks ago, they started failing on Nightly. They started failing on Beta too recently with "Error retrieving Push subscription.".

With no additional details, debugging this is very painful.
The same can happen to developers, I can see a few StackOverflow questions and issues mentioning this, e.g.:
https://stackoverflow.com/questions/56378140/i-get-domexception-error-retrieving-push-subscription-while-using-firefox-67
https://stackoverflow.com/questions/34489810/firefox-push-api-aborterror-error-retrieving-push-subscription
https://github.com/mozilla/wp-web-push/issues/157

Comment 1

[Marco Castelluccio [:marco]]

The library is at https://github.com/web-push-libs/web-push.
The test is at https://github.com/web-push-libs/web-push/blob/5df44693b0a466faedeb2b0a89d6606cb0f16e0f/test/testSelenium.js and https://github.com/web-push-libs/web-push/tree/5df44693b0a466faedeb2b0a89d6606cb0f16e0f/test/data/demo.
The test can be run by running "npm run test". If you want to specifically run the integration test only on Beta or Nightly only, you can replace "test*" with "testSelenium.js" at https://github.com/web-push-libs/web-push/blob/5df44693b0a466faedeb2b0a89d6606cb0f16e0f/package.json#L13 and add:

  if (browser.getPrettyName() !== 'Firefox Nightly') {
    return;
  }

at https://github.com/web-push-libs/web-push/blob/5df44693b0a466faedeb2b0a89d6606cb0f16e0f/test/testSelenium.js#L202.

Comment 2

[Marco Castelluccio [:marco]]

If you want to use a custom build of Firefox, you can add something like:

    browser.getExecutablePath = function() {
        return "/home/marco/Documenti/FD/mozilla-unified/obj/dist/bin/firefox";
    };

to https://github.com/web-push-libs/web-push/blob/5df44693b0a466faedeb2b0a89d6606cb0f16e0f/test/testSelenium.js#L64.

Comment 3

[Jan Varga [:janv]]

P5 for now

Comment 4

[Marco Castelluccio [:marco]]

69 (release) is failing too, so the library is no longer tested against Firefox.

Comment 5

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

(This is not a bug but is annoying)