Closed Bug 1565836 Opened 5 years ago Closed 5 years ago

All custom search engines are lost. search.json.mozlz4 is probably reset to default on every launch

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Version:
70 Branch
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- verified

People

(Reporter: Fanolian+BMO, Unassigned)

References

(Regression)

Details

(4 keywords, Whiteboard: [fixed by patch backout from bug #1556789])

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0
Build ID: 20190713095401

It is a data loss

Steps to reproduce

  1. Make some custom search engines before 2019-07-13 build 20190713095401.
  2. Update to Nightly 2019-07-13 build 20190713095401

Actual result

  1. All custom search engines are lost.
  2. My search.json.mozlz4 filesize is reduced from 132KB (around 30 custom engines) to 3 KB (only default engines are left).

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ddd8910e7d83e2a2c43395357c9ae889a5a5aa6f&tochange=e712c1b80f6485ce0246c8c380193c51321c5a60

It contains bug 1558944 and bug 1556789. I am pretty sure this bug is causing a data loss.
I am filing a new bug regarding the issue.

Severity: normal → blocker
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox70: --- → affected
tracking-firefox70: --- → ?
Flags: needinfo?(mixedpuppy)
Keywords: dataloss, nightly-community, regression, reproducible
Regressed by: 1556789

Thank you for the report, code sheriffs are backing out bug 1556789 and will kick off new Nightlies. Sorry for the trouble.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Component: General → Search
Product: WebExtensions → Firefox
Version: Firefox 70 → 70 Branch

The respun build seems fixed -- after I restored my search.json.mozlz4 from a backup from a few days ago.

Fixed for me too on 20190713175429. (The part where search.json.mozlz4 is reset on every launch)

:Virtual would you please mark this bug as fixed? I don't have the permission to do so. Thanks.

status-firefox70: affected → fixed
tracking-firefox70: ? → ---
Flags: needinfo?(mixedpuppy) → needinfo?(Virtual)
Summary: All custom search engines are lost. search.json.mozlz4 is probably reset to default → All custom search engines are lost. search.json.mozlz4 is probably reset to default on every launch
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(Virtual)
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Status: RESOLVED → VERIFIED
status-firefox70: fixed → verified
Whiteboard: [fixed by patch backout from bug #1556789]

I'm seeing this in 68.0.1, can't switch my default search to Google.

You need to log in before you can comment on or make changes to this bug.