1565840 - cmd_killThread command: TypeError: this.notificationbox is undefined

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[alta88]

when attempting to uncheck an 'ignore thread' menuitem. The notificationbox doesn't belong to DefaultController but to FolderPaneController, so can't use |this| there.

Comment 1

[Jorg K (CEST = GMT+2)]

Alex, you worked on notification stuff, could you please take a look.

OK, on the message menu, "Ignore Thread" has a check mark, but on the context menu it doesn't have one. That's a bug too, right?

Looks like ignore sub-thread doesn't work either.

An error occurred executing the cmd_killThread command: TypeError: this.notificationbox is undefined globalOverlay.js:83
goDoCommand chrome://global/content/globalOverlay.js:83
oncommand chrome://messenger/content/messenger.xul:1

Comment 2

[alta88]

easy fix, change |this| to |FolderPaneController| in two places, here and just below:
https://searchfox.org/comm-central/source/mail/base/content/mail3PaneWindowCommands.js#703

it helps to have View-Threads-Ignored Threads checked, and have the thread column selected.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1565840-fix-ignore-thread.patch

Patch as per comment #2, author Alta88. This seems to restore the original behaviour.

If you ignore a thread, "Ignore Thread" gets a check mark in the main window, but not in the context menu. Is that intentional? It's the same in TB 60 and TB 52, hmm.

Also, when I ignore a tread, I've see a case where the "Ignore Thread" item was greyed-out in the main menu, but now I can't reproduce it. Anyway, that's out of scope here.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dd1eac384cfd
fix access to notification box for 'Ignore (Sub)Thread'. r=jorgk DONTBUILD

Comment 5

[Jorg K (CEST = GMT+2)]

(In reply to Jorg K (GMT+2) from comment #3)

If you ignore a thread, "Ignore Thread" gets a check mark in the main window "message" menu, but not in the context menu. Is that intentional? It's the same in TB 60, TB 52, TB 38 and TB 24, hmm. The context menu has provision for a checkbox.

Magnus, Alta88, is that intentional or a bug?

Comment 6

[Magnus Melin [:mkmelin]]

I get a checkmark in the context menu too (linux, trunk).

Comment 7

[Jorg K (CEST = GMT+2)]

Filed bug 1566027 for the missing check mark. Strange that no one has complained since TB 24.

Comment 8

[Jorg K (CEST = GMT+2)]

TB 68 beta 5:
https://hg.mozilla.org/releases/comm-beta/rev/3820464b6b6978ce7e8f49e8dc6d545918ab5e21

TB 69 beta:
https://hg.mozilla.org/releases/comm-beta/rev/ef4e72ba20242308037bb8f956b8548afef4c1f5