1565877 - bugs/256180-4.html crashes mingwclang x86 opt build

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, defect)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Runs/dumps here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=372a9bb41490f95a1292c34ccb86e89251457440&selectedJob=256363517

Strangely enough for me it does not crash when I load this file locally...

Bug 1530033 was the same thing for aarch64 and https://bugzilla.mozilla.org/show_bug.cgi?id=1530033#c4 says

The test relies on Firefox having a non-default runtime stack size on Windows. https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/config/config.mk#293 needs to be adjusted to set the stack size to 8 MB on aarch64 Windows, too.

They fixed the stack size in Bug 1536575

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1565877 - Bump the stack size on mingwclang builds r?#build

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

[Tracking Requested - why for this release]: This fixes a corner-case bug in firefox

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 9078036 [details]
Bug 1565877 - Bump the stack size on mingwclang builds r?#build

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fixes a corner-case bug in firefox: extensively-nested DOM elements caused a stack overflow in our html parser that wa sinconsistent with other engines. We needed to bump the stack size to avoid crashing on the same input.
• User impact if declined: Tor will need to backport the patch
• Fix Landed on Version: 70a1: 7/18/2019
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects MinGW builds.
• String or UUID changes made by this patch:

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4367ea6b63f
Bump the stack size on mingwclang builds r=firefox-build-system-reviewers,mshal

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/c4367ea6b63f

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9078036 [details]
Bug 1565877 - Bump the stack size on mingwclang builds r?#build

Bumps the stack size for MinGW builds. NPOTB for official Firefox builds. Approved for 68.1esr.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/dbf28eeb8626