1565921 - Multiple XUL textboxes converted to HTML inputs stopped having edit context menus

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Alice0775 White]

Reproducible: always

Steps To Reproduce:

1. Start firefox.exe -p
2. Create Profile... > Next
3. Right click on "Enter New Profile Name" textbox

Actual Results:
Nothing happens

Expected Results:
Context menu should pop up

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c6177164dbc053a2c8819967bd6ff8f294dc5c4a&tochange=96211a78568ef5b13403648ce1b1a4ee7f4ea8e9

Regressed by: 96211a78568ef5b13403648ce1b1a4ee7f4ea8e9 Tim Nguyen — Bug 1562240 - Remove XUL textbox from toolkit/profile/content/createProfileWizard.xul. r=Gijs

Tim Nguyen, your patch seems to cause the regression. Can you please look into this?

Comment 1

[Alice0775 White]

Attachment: Create Profile Wizerd

Comment 2

[Tim Nguyen :ntim]

Thanks for catching this!

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1565921 - Load editMenuOverlay.js and globalOverlay.js on documents with HTML inputs. r=Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/960f2a6b10bc
Load editMenuOverlay.js and globalOverlay.js on documents with HTML inputs. r=Gijs

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/960f2a6b10bc

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 7

[Tim Nguyen :ntim]

Comment on attachment 9078035 [details]
Bug 1565921 - Load editMenuOverlay.js and globalOverlay.js on documents with HTML inputs. r=Gijs

Beta/Release Uplift Approval Request

• User impact if declined: Some dialogs with textboxes (notably the create new profile one) will lose their edit context menu
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just importing some scripts that are already well-used across the source code
• String changes made/needed: No

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9078035 [details]
Bug 1565921 - Load editMenuOverlay.js and globalOverlay.js on documents with HTML inputs. r=Gijs

Fixes a new regression in 69 causing context menus to not appear on some dialogs with HTML inputs. Approved for 69.0b6.

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/98b8c0f975bc

Comment 10

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 70.0a1 (2019-07-17) on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.

Comment 11

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 69.0b6 on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.