1565965 - Layout Debugger fails to load documents

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Bug 1565965 - Allow unsafe loads in the Layout Debugger.

Comment 2

[:Gijs (he/him)]

Gah, sorry for missing this. :-(

Is there a bug to make the layout debugger use e10s or are we deliberately not wanting to do so?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I would like to make it use e10s, but I'm not sure if there's a bug for it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afeff85950a6
Allow unsafe loads in the Layout Debugger. r=bzbarsky

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/afeff85950a6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this.

Comment 7

[Cameron McCormack (:heycam)]

I don't think it's important to uplift, as it has no end user impact. If developers need to debug an issue on Beta, they can still use a regular browser window.

Comment 8

[Cameron McCormack (:heycam)]

But since the regressing bug is going to be uplifted, may as well uplift this at the same time.

Comment 9

[Cameron McCormack (:heycam)]

Comment on attachment 9078072 [details]
Bug 1565965 - Allow unsafe loads in the Layout Debugger.

Beta/Release Uplift Approval Request

• User impact if declined: No end user impact. Developer impact if trying to debug an issue on Beta is that they'll be unable to use the Layout Debugger.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's #ifdefed code that is not enabled in release.
• String changes made/needed:

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9078072 [details]
Bug 1565965 - Allow unsafe loads in the Layout Debugger.

Fixes a regression from bug 1560178. Approved for 69.0b7.

Comment 12

[Razvan Maries]

Conflict when I tried to uplift:
warning: conflicts while merging docshell/base/nsDocShell.cpp!

Comment 13

[:Gijs (he/him)]

(In reply to Razvan Maries from comment #12)

Conflict when I tried to uplift:
warning: conflicts while merging docshell/base/nsDocShell.cpp!

The patches in bug 1560178 need uplifting first.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cbf0daa7f713

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9078072 [details]
Bug 1565965 - Allow unsafe loads in the Layout Debugger.

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1560178#c34.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/0b0cda112909