Closed Bug 1565978 Opened 5 months ago Closed 2 months ago

Request list keyboard navigation: consider unbinding the Left and Right arrow keys

Categories

(DevTools :: Netmonitor, defect, P3)

defect

Tracking

(firefox72 fixed)

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: fvsch, Assigned: alexand.dominguez, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Currently the request list's selected item can be changed with the following arrow keys:

  • Previous item: Left and Up
  • Next item: Right and Down

Using the Left and Right keys might be a problem because their meaning is only correct in left-to-right locales. Currently in RTL we still use the Right key for "next", and in my quick test it felt wrong.

Another related issue is that we use the Left and Right arrow keys in tree structures for "expand" and "collapse" actions.

I'm wondering if we should:

  1. Not bind the Left and Right keys at all in the requests list
  2. Or bind them to "Show request details" and "Hide request details"
  3. Or keep them, but make sure we interpret Left and Right depending on the text direction

Yura, do you have an opinion on this maybe?

Flags: needinfo?(yzenevich)

(In reply to Florens Verschelde :fvsch from comment #0)

Currently the request list's selected item can be changed with the following arrow keys:

  • Previous item: Left and Up
  • Next item: Right and Down

Using the Left and Right keys might be a problem because their meaning is only correct in left-to-right locales. Currently in RTL we still use the Right key for "next", and in my quick test it felt wrong.

Another related issue is that we use the Left and Right arrow keys in tree structures for "expand" and "collapse" actions.

I'm wondering if we should:

  1. Not bind the Left and Right keys at all in the requests list

I agree, I very much prefer not to use left/right for these purposes.

  1. Or bind them to "Show request details" and "Hide request details"
  2. Or keep them, but make sure we interpret Left and Right depending on the text direction

Yura, do you have an opinion on this maybe?

Flags: needinfo?(yzenevich)

The priority flag is not set for this bug.
:Honza, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(odvarko)
Flags: needinfo?(odvarko)
Keywords: good-first-bug
Priority: -- → P3

I see this is still actual. Mind if I take a stab at this?

Hi Alex. Still something we want to do. :) I'll assign you to the bug.

To get started building Firefox, you can follow this guide:
https://docs.firefox-dev.tools/getting-started/build.html

After checking out the mozilla-central repository, I recommend creating a mozilla-central/mozconfig file with this content before trying to build Firefox for the first time:
https://docs.firefox-dev.tools/getting-started/build.html#building-even-faster-with-artifact-builds

Assignee: nobody → alexand.dominguez
Mentor: florens

The switch cases for the left and right arrow keys within the onKeyDown handler were removed so as not to assign a value to delta var when they trigger an event.

Hi Florens, I've submitted my first, possibly naive, solution to this bug. It is in Phabricator now.

Flags: needinfo?(florens)

Added some comments in the patch.

possibly naive

No it looks just right. :)

Flags: needinfo?(florens)

Sounds good, thank you.

I will get to work on FrameListContent.js and running the tests. Regards.

Status: NEW → ASSIGNED

Revision in Phabricator has been updated. Automated tests were run; all passed. Individual tests were attempted; none exist.

Attachment #9101616 - Attachment description: Bug 1565978 - Removed switch cases for left and right arrow keys. r=fvsch! → Bug 1565978 - Stop changing the currently selected row in Network with left and right keys. r=fvsch!

Thanks Alex, this is working well indeed.

I took the liberty to change the commit message to reflect the intent of the fix more than the implementation details.

Pushed by florens@fvsch.com:
https://hg.mozilla.org/integration/autoland/rev/122109471f12
Stop changing the currently selected row in Network with left and right keys. r=fvsch

Thanks for the opportunity, and for your mentorship. Regards.

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
QA Whiteboard: [qa-72b-p2]
You need to log in before you can comment on or make changes to this bug.