Request list keyboard navigation: consider unbinding the Left and Right arrow keys
Categories
(DevTools :: Netmonitor, defect, P3)
Tracking
(firefox72 fixed)
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: fvsch, Assigned: alexand.dominguez, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
Bug 1565978 - Stop changing the currently selected row in Network with left and right keys. r=fvsch!
47 bytes,
text/x-phabricator-request
|
Details | Review |
Currently the request list's selected item can be changed with the following arrow keys:
- Previous item: Left and Up
- Next item: Right and Down
Using the Left and Right keys might be a problem because their meaning is only correct in left-to-right locales. Currently in RTL we still use the Right key for "next", and in my quick test it felt wrong.
Another related issue is that we use the Left and Right arrow keys in tree structures for "expand" and "collapse" actions.
I'm wondering if we should:
- Not bind the Left and Right keys at all in the requests list
- Or bind them to "Show request details" and "Hide request details"
- Or keep them, but make sure we interpret Left and Right depending on the text direction
Yura, do you have an opinion on this maybe?
Comment 1•4 years ago
|
||
(In reply to Florens Verschelde :fvsch from comment #0)
Currently the request list's selected item can be changed with the following arrow keys:
- Previous item: Left and Up
- Next item: Right and Down
Using the Left and Right keys might be a problem because their meaning is only correct in left-to-right locales. Currently in RTL we still use the Right key for "next", and in my quick test it felt wrong.
Another related issue is that we use the Left and Right arrow keys in tree structures for "expand" and "collapse" actions.
I'm wondering if we should:
- Not bind the Left and Right keys at all in the requests list
I agree, I very much prefer not to use left/right for these purposes.
- Or bind them to "Show request details" and "Hide request details"
- Or keep them, but make sure we interpret Left and Right depending on the text direction
Yura, do you have an opinion on this maybe?
Comment 2•4 years ago
|
||
The priority flag is not set for this bug.
:Honza, could you have a look please?
For more information, please visit auto_nag documentation.
Updated•4 years ago
|
Comment 3•4 years ago
|
||
Here is the place where we handle keyboard events:
Honza
Assignee | ||
Comment 4•4 years ago
|
||
I see this is still actual. Mind if I take a stab at this?
Reporter | ||
Comment 5•4 years ago
|
||
Hi Alex. Still something we want to do. :) I'll assign you to the bug.
To get started building Firefox, you can follow this guide:
https://docs.firefox-dev.tools/getting-started/build.html
After checking out the mozilla-central
repository, I recommend creating a mozilla-central/mozconfig
file with this content before trying to build Firefox for the first time:
https://docs.firefox-dev.tools/getting-started/build.html#building-even-faster-with-artifact-builds
Reporter | ||
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
The switch cases for the left and right arrow keys within the onKeyDown handler were removed so as not to assign a value to delta var when they trigger an event.
Assignee | ||
Comment 7•4 years ago
|
||
Hi Florens, I've submitted my first, possibly naive, solution to this bug. It is in Phabricator now.
Reporter | ||
Comment 8•4 years ago
|
||
Added some comments in the patch.
possibly naive
No it looks just right. :)
Assignee | ||
Comment 9•4 years ago
|
||
Sounds good, thank you.
I will get to work on FrameListContent.js and running the tests. Regards.
Updated•4 years ago
|
Assignee | ||
Comment 10•4 years ago
|
||
Revision in Phabricator has been updated. Automated tests were run; all passed. Individual tests were attempted; none exist.
Updated•4 years ago
|
Reporter | ||
Comment 11•4 years ago
|
||
Thanks Alex, this is working well indeed.
I took the liberty to change the commit message to reflect the intent of the fix more than the implementation details.
Comment 12•4 years ago
|
||
Pushed by florens@fvsch.com: https://hg.mozilla.org/integration/autoland/rev/122109471f12 Stop changing the currently selected row in Network with left and right keys. r=fvsch
Assignee | ||
Comment 13•4 years ago
|
||
Thanks for the opportunity, and for your mentorship. Regards.
Comment 14•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Description
•