1565981 - hex color notation issue after update to 68.0 for Firefox Quantun

Status: RESOLVED WONTFIX

(Core :: CSS Parsing and Computation, defect)

Description

[paraskevakosg]

Attachment: moz_color_invalid_hex.jpg

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

I am using hex color notation in style.css with Firefox Quantum (64-bit).

Actual results:

In my style.css I have the following rule:
{
background: -moz-linear-gradient(center top ,#87C540,#A8EC58);
}
and from inspector I get : "Invalid property value".
On the other hand if I change it with rgb:
{
background: -moz-linear-gradient(rgb(135, 197, 64), rgb(168, 236, 88));
}
then CSS renders without issue in browser.

Expected results:

CSS for hex color notation should be rendered as it used to https://caniuse.com/#search=hex%20color%20notation.

Comment 1

[paraskevakosg]

Issue relates with https://bugzilla.mozilla.org/show_bug.cgi?id=1313768

Comment 2

[Antonis]

same problem for me

Comment 3

[Aggeliki]

Same also!

Comment 4

[Simona Badau, Desktop QA]

Could you please install the tool mozregression and try to narrow down a regression range?
See http://mozilla.github.io/mozregression/ for details.

Comment 5

[paraskevakosg]

Attachment: mozregression.log

Comment 6

[paraskevakosg]

Attachment: Bisection_information.log

Comment 7

[paraskevakosg]

Attachment: mozreg.JPG

Comment 8

[paraskevakosg]

Thanks a lot for the feedback Simona.

Attached you can find:
mozregression.log,
Bisection_information.log,
mozreg.jpg

I ran the regression and the following Bug ID was returned:

2019-07-22T19:38:05: INFO : Narrowed inbound regression window from [eb170900, a484a262] (3 builds) to [bd1d3ebd, a484a262] (2 builds) (~1 steps left)
2019-07-22T19:38:06: DEBUG : Found commit message:
Bug 1547939 - Add a pref for a simpler -moz- gradient parsing. r=dholbert

Comment 9

[paraskevakosg]

Relates with repo autoland : https://hg.mozilla.org/integration/autoland

Comment 10

[Emilio Cobos Álvarez (:emilio)]

This is expected. We simplified the parsing of Mozilla-specific gradients to be less special and more similar to other gradients. That gradient simply doesn't work anymore.

Is there any site broken because of this? Or is this mozilla-specific CSS (like a theme or such)? I was careful of ensuring all the regressions of previous attempts at removing them weren't broken. You can use standard linear gradient syntax to achieve this, see https://developer.mozilla.org/en-US/docs/Web/CSS/linear-gradient.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:emilio, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

This syntax was prefixed and mozilla-specific. You can accomplish the same with the standard gradient syntax that is supported everywhere.

I'm happy to help update the gradients if you have any questions or what not. But I think this is WONTFIX unless I get a reply to comment 10 and something is severely broken because of this.

Comment 13

[Kohei Yoshino [:kohei]]

It’s documented at https://www.fxsitecompat.dev/en-CA/docs/2019/non-standard-complex-syntax-is-no-longer-supported-in-moz-prefixed-css-gradients/