Closed Bug 1566027 Opened 3 months ago Closed 3 months ago

No check box for Ignore Thread, Ignore Subthread or Watch Thread in context menu on Windows

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set

Tracking

(thunderbird68 fixed, thunderbird69 fixed, thunderbird70 fixed)

RESOLVED FIXED
Thunderbird 70.0
Tracking Status
thunderbird68 --- fixed
thunderbird69 --- fixed
thunderbird70 --- fixed

People

(Reporter: jorgk, Assigned: Paenglab)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1565840 +++

See bug 1565840 comment #5. This is broken since at least TB 24 on Windows.

Is that a style issue?

Flags: needinfo?(richard.marti)

Per ni in the above bug, the checks are displayed/updated correctly in both threadpane context and message->ignore thread menus, on linux.

The three menuitems missed the type="checkbox". Linux showed without them but Windows didn't prepared the items to show a checkbox. Tested the patch on Linux too and it works (before no empty checkbox was shown, now it is).

I checked also other menuitems and found no missing type="checkbox".

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Attachment #9078204 - Flags: review?(jorgk)
Comment on attachment 9078204 [details] [diff] [review]
1566027-add-type-checkbox-thread-context-menus.patch

Great. Broken since at least TB 24 and no one complained :-(
Attachment #9078204 - Flags: review?(jorgk)
Attachment #9078204 - Flags: review+
Attachment #9078204 - Flags: approval-comm-beta+
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 70.0

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/3e8b0b7252ae
Add type="checkbox" to the context thread menus. r=jorgk

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.