1566027 - No check box for Ignore Thread, Ignore Subthread or Watch Thread in context menu on Windows

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Jorg K (GMT+2)]

+++ This bug was initially created as a clone of Bug #1565840 +++

See bug 1565840 comment #5. This is broken since at least TB 24 on Windows.

Is that a style issue?

Comment 1

[alta88]

Per ni in the above bug, the checks are displayed/updated correctly in both threadpane context and message->ignore thread menus, on linux.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1566027-add-type-checkbox-thread-context-menus.patch

The three menuitems missed the type="checkbox". Linux showed without them but Windows didn't prepared the items to show a checkbox. Tested the patch on Linux too and it works (before no empty checkbox was shown, now it is).

I checked also other menuitems and found no missing type="checkbox".

Comment 3

[Jorg K (GMT+2)]

Comment on attachment 9078204 [details] [diff] [review]
1566027-add-type-checkbox-thread-context-menus.patch

Great. Broken since at least TB 24 and no one complained :-(

Comment 4

[Jorg K (GMT+2)]

TB 68 beta 5:
https://hg.mozilla.org/releases/comm-beta/rev/3d0023b8ba2cfd83d221a0270fabd0389dda14ff

TB 69 beta:
https://hg.mozilla.org/releases/comm-beta/rev/172233075ffda8f444352817b7c71eda39ca6f36

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3e8b0b7252ae
Add type="checkbox" to the context thread menus. r=jorgk