156606 - Identify pages viewed as source in title

Status: RESOLVED FIXED

(Camino Graveyard :: General, enhancement)

Description

[Steve Smart]

In Chimera/20020709 on Mac OS 10.1.5, if you view the source of a page in a new
window or tab, the title of the source's window or tab is the URL of the page
you are viewing the source of, but it does not identify itself as being source
code in the title.

For example, if you go to apple.com and view the source, the title of the source
window or tab will be, "http://www.apple.com/". It would be more clear if the
window were named, "Source of http://www.apple.com"

Mozilla names source windows "Source of: http://www.somewebsite.com - Mozilla"
so this is a Chimera-specific issue.

Comment 1

[Greg K.]

Confirmed using Chimera/20020708. Steve's suggestion is a good one (but let's
not append "- Chimera" à la Mozilla here).

Comment 2

[Kasper Nauwelaerts]

Attachment: Adds localizable 'Source of ' before view-source tabs and windows

Adds localizable 'Source of ' before view-source tabs and windows.

Comment 3

[Simon Fraser [no longer active]]

Mine.

Comment 4

[Jasper]

Bump. Could this land, seems like a very simple solution to something that might
irritate people.

Comment 5

[Jasper]

Please review. Or check in.

Comment 6

[Jasper]

Mike.

Comment 7

[Jasper]

Mike I'm putting this on the 0.8 list since it's such a nice patch. I have been
running this patch i one of David Haas's builds and never encountered problems.

It's a small detail just like the one that changes the window title when in
Bookmarks view mode.

Reset as needed.

Comment 8

[Mike Pinkerton (not reading bugmail)]

this patch isn't l10n savvy, but it should be easy to make it so. working on it
and will land.

Comment 9

[Mike Pinkerton (not reading bugmail)]

cleaned up and landed.

Comment 10

[Josh Aas]

Pretty big problem... Load your home page, select view source from the menu,
then flip back and forth from the source page and the original a few times.
Notice that the title of the source view tab gets "Source of " prefixed to it
multiple times. Shouldn't be too hard to fix.

Comment 11

[Josh Aas]

Attachment: tabbing/window titles cleanup

This patch fixes the problem where "Source of " duplicates when tabbing and
cleans up the code for the entire method in charge of that.

Comment 12

[Josh Aas]

I found out that my patch causes this failure when switching back and forth
between the original and source view tabs:

2004-02-18 16:41:06.452 Camino[12200] *** Assertion failure in -[BrowserWindow
setTitle:], AppKit.subproj/NSWindow.m:1490

2004-02-18 16:41:06.523 Camino[12200] Invalid parameter not satisfying: aString
!= nil

I don't have time to fix it now, but I will in a bit if nobody else does.

Comment 13

[Josh Aas]

Attachment: source text repeat patch v2

Comment 14

[Mike Pinkerton (not reading bugmail)]

landed patch with tweaks.