1566066 - HTML5 audio tag with a very specific mp3 audio file doesn't work

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[florian69666]

Attachment: original failed.mp3

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

<audio preload="auto" src="original failed.mp3" controls=""></audio>
Click on play button

Actual results:

In the console tab : Media resource "original failed.mp3" could not be decoded.

Expected results:

If I encode the file with same configuration, it begings to work fine.
This file works on all others browsers in HTML5 audio tag

Comment 2

[:Gijs (he/him)]

FWIW, on beta I see:

Media resource https://bugzilla.mozilla.org/attachment.cgi?id=9078152 could not be decoded, error: Error Code: NS_ERROR_DOM_MEDIA_METADATA_ERR (0x806e0006)

in the console.

Comment 3

[Michael Froman [:mjf]]

I can confirm this.

Comment 4

[Michael Froman [:mjf]]

Paul, any thoughts on who should take a look at this?

Comment 5

[Paul Adenot (:padenot)]

I can't seem to find a Firefox version that can play it, and ffprobe complains a bit that there is lot of garbage. Alastor, do you have a minute to have a look?

Comment 6

[Alastor Wu [:alwu]]

As the file size in ID3 header is zero, it made mp3 parser think of that it hasn't parsed the header yet, which causes skipping 10 bytes (header size) again and again and then affects all the following parsing.

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1566066 - part1 : use Maybe to distinguish size 0 and uninitialized value.

We found there is a mp3 where the size is empty in its ID3 header, which makes mp3 parser think of that we haven't parsed the header yet, and then skip unnecessary bytes again and again.

We should use Maybe to know whether we finish parsing the size or not.

Comment 8

[Alastor Wu [:alwu]]

Attachment: Bug 1566066 - part2 : add 'empty_size.mp3' to playback test.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d626079f7a20
part1 : use Maybe to distinguish size 0 and uninitialized value. r=jya
https://hg.mozilla.org/integration/autoland/rev/6b69fa403574
part2 : add 'empty_size.mp3' to playback test. r=jya

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d626079f7a20
https://hg.mozilla.org/mozilla-central/rev/6b69fa403574