Closed
Bug 1566135
Opened 5 years ago
Closed 5 years ago
Simplify margin styles for devtools-separator
Categories
(DevTools :: General, task)
DevTools
General
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: fvsch, Assigned: fvsch)
Details
Attachments
(1 file)
I used a handful of CSS variables in an update to devtools-separator
styles last year but those are mostly needless extension points. This code:
.some-context {
--separator-margin-inline: 3px;
}
can easily be replaced with:
.some-context .devtools-separator {
margin-inline: 3px;
}
Removing those variables should limit code complexity, plus there are concerns about the perf impact of too many CSS vars.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → florens
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by florens@fvsch.com: https://hg.mozilla.org/integration/autoland/rev/5adccac9ec7b Remove devtools-separator margin variables; r=ntim
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•