1566144 - Disable SQLite's double-quoted string literal feature

Status: NEW

(Toolkit :: Storage, task, P5)

Description

[Ryan VanderMeulen [:RyanVM]]

The SQLite 3.29.0 update adds a new SQLITE_DQS=0 build-time option which disables support for the now-deprecated double-quoted string literal feature.

A Try push with that option set was very orange:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=0e0c565c849bd9ac831794d51cf7a10858ddcc7f

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Yes, we used double quoted literals extensively, it may take some time to fix all cases.

Comment 2

[Lina Butler [:lina]]

Whoa, that's good to know! I'd thought double-quoted strings were the norm, given how often we use them in our queries. 😆🤦‍♀️

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Here's a newer Try push. Still very orange.
https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=ebe23967d6037a23740dee3893ac72fcb98328e2

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

yeah, we can't do this without some planning and a person checking SQL line by line, things won't fix by themselves.