Closed Bug 1566177 Opened 3 months ago Closed 3 months ago

All number boxes styled with incorrect font size in TB 68 beta

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(thunderbird68+ fixed, thunderbird69 fixed)

VERIFIED FIXED
Thunderbird 69.0
Tracking Status
thunderbird68 + fixed
thunderbird69 --- fixed

People

(Reporter: jorgk, Assigned: Paenglab)

Details

Attachments

(3 files)

Attached image numbers too big.png

See picture.

Flags: needinfo?(richard.marti)

Also visible in attachment 9074996 [details].

Attached image NumbersSameHeight.png

Hmm, here the fonts have the same height.

Flags: needinfo?(richard.marti)
Summary: All number boxes styles with incorrect font size in TB 68 beta → All number boxes styled with incorrect font size in TB 68 beta

OK, the number boxes see to take the font size set in
Options > Display, General, Advanced, Latin into account. Set that to 28 you will see the effect. I have it set to 16 when the "standard" size appears to be 15. It looks OK with 15.

It's not right that that setting affects the formatting of the number boxes.

Flags: needinfo?(richard.marti)

Also note that the font for the word "Latin" in the menu box is too small.

Yes, on beta it follows this setting, on Daily not. Strange.

(In reply to Jorg K (GMT+2) from comment #4)

Also note that the font for the word "Latin" in the menu box is too small.

There is rule that is no more needed. :-(

Flags: needinfo?(richard.marti)

This patch is for beta (68 and 69) only. For 70 I fix this in bug 1498332 because it needs an additional fix for a change in this bug.
[edit] This fixes the smaller font in the menulist only. I don't know why the numberboxes use the font size from the prefs (maybe because they are HTML?).

Assignee: nobody → richard.marti
Attachment #9078373 - Flags: review?(jorgk)
Attachment #9078373 - Flags: approval-comm-beta?

I guess that the input boxes follow the pref since they are HTML editors like the compose window or the chat input area and are handled like any HTML message that doesn't set a font size. Can't we just set a fixed size that matches the size of the other text?

Okay, I found why this happens: in global.css was the font: inherit; lost. Bug 1563529 brings it back (https://hg.mozilla.org/mozilla-central/rev/9bfe9db3e7b1) but unfortunately for 69 and not 68. We could ask to uplift to 68 ESR or you could land it for TB only like you've done with other patches.

Comment on attachment 9078373 [details] [diff] [review]
1566177-selectLangs-remove-rule.patch

Thanks. I'll do some release acrobatics to fix the html:input issue as well.
Attachment #9078373 - Flags: review?(jorgk)
Attachment #9078373 - Flags: review+
Attachment #9078373 - Flags: approval-comm-beta?
Attachment #9078373 - Flags: approval-comm-beta+
Target Milestone: --- → Thunderbird 69.0

Looks very nice now in TB 68 beta, thanks, Richard, for the patch and the research.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.