Closed
Bug 1566211
Opened 5 years ago
Closed 5 years ago
Crash in [@ core::result::unwrap_failed<T> | webrender_bindings::bindings::wr_try_load_startup_shaders_from_disk]
Categories
(Core :: Graphics: WebRender, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla70
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox-esr68 | --- | unaffected |
firefox68 | --- | unaffected |
firefox69 | --- | unaffected |
firefox70 | --- | fixed |
People
(Reporter: marcia, Assigned: jnicol)
References
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
This bug is for crash report bp-899eb047-e026-4cca-aade-702e40190715.
Seen while looking at nightly crash stats: https://bit.ly/2XQyI18
All crashes have this moz crash reason: called Result::unwrap()
on an Err
value: Os { code: 1392, kind: Other, message: "The file or directory is corrupted and unreadable." }
Top 10 frames of crashing thread:
0 xul.dll GeckoCrash toolkit/xre/nsAppRunner.cpp:5153
1 xul.dll static void gkrust_shared::panic_hook toolkit/library/rust/shared/lib.rs:246
2 xul.dll static void core::ops::function::Fn::call<fn src/libcore/ops/function.rs:69
3 xul.dll static void std::panicking::rust_panic_with_hook src/libstd/panicking.rs:478
4 xul.dll static void std::panicking::continue_panic_fmt src/libstd/panicking.rs:381
5 xul.dll static void std::panicking::rust_begin_panic src/libstd/panicking.rs:308
6 xul.dll static void core::panicking::panic_fmt src/libcore/panicking.rs:85
7 xul.dll static <NoType> core::result::unwrap_failed<std::io::error::Error> src/libcore/macros.rs:18
8 xul.dll void webrender_bindings::bindings::wr_try_load_startup_shaders_from_disk gfx/webrender_bindings/src/bindings.rs:1078
9 xul.dll void mozilla::wr::WebRenderProgramCache::WebRenderProgramCache gfx/webrender_bindings/RenderThread.cpp:906
Comment 1•5 years ago
|
||
Jamie - could you take a peak at this?
Assignee | ||
Comment 2•5 years ago
|
||
A few potential error cases were being unwrapped, resulting in a very
small number of crashes. These errors can be safely ignored as the
program cache is non-critical, so this change makes us log the error
and continue rather than panicking.
Pushed by jnicol@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dd28ebddbd63 Handle filesystem errors in webrender program cache. r=bholley
Comment 4•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Updated•5 years ago
|
Assignee: nobody → jnicol
Updated•5 years ago
|
status-firefox68:
--- → unaffected
status-firefox69:
--- → unaffected
status-firefox-esr60:
--- → unaffected
status-firefox-esr68:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•