1566230 - devicepool infinite loop when duplicate projects

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: General, defect, P3)

Description

[Andrew Erickson [:aerickson]]

Also, figure out why duplicate projects are being created.

Jul 15 21:48:19 bitbar-devicepool-0 bash[26376]: Traceback (most recent call last):
Jul 15 21:48:19 bitbar-devicepool-0 bash[26376]:   File "/home/bitbar/mozilla-bitbar-devicepool/mozilla_bitbar_devicepool/main.py", line 170, in <module>
Jul 15 21:48:19 bitbar-devicepool-0 bash[26376]:     main()
Jul 15 21:48:19 bitbar-devicepool-0 bash[26376]:   File "/home/bitbar/mozilla-bitbar-devicepool/mozilla_bitbar_devicepool/main.py", line 167, in main
Jul 15 21:48:19 bitbar-devicepool-0 bash[26376]:     args.func(args)
Jul 15 21:48:19 bitbar-devicepool-0 bash[26376]:   File "/home/bitbar/mozilla-bitbar-devicepool/mozilla_bitbar_devicepool/main.py", line 55, in test_run_manager
Jul 15 21:48:19 bitbar-devicepool-0 bash[26376]:     configuration.configure(bitbar_configpath, filespath=args.files, update_bitbar=args.update_bitbar)
Jul 15 21:48:19 bitbar-devicepool-0 bash[26376]:   File "/home/bitbar/mozilla-bitbar-devicepool/mozilla_bitbar_devicepool/configuration.py", line 74, in configure
Jul 15 21:48:19 bitbar-devicepool-0 bash[26376]:     configure_projects(update_bitbar=update_bitbar)
Jul 15 21:48:19 bitbar-devicepool-0 bash[26376]:   File "/home/bitbar/mozilla-bitbar-devicepool/mozilla_bitbar_devicepool/configuration.py", line 174, in configure_projects
Jul 15 21:48:19 bitbar-devicepool-0 bash[26376]:     raise Exception('project {} has {} duplicates'.format(project_name, len(bitbar_projects) - 1))
Jul 15 21:48:19 bitbar-devicepool-0 bash[26376]: Exception: project mozilla-gw-unittest-g5 has 1 duplicates

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:bc, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Bob Clary [:bc] (inactive)]

P3 to be handled as time permits.

I believe we figured out the why... the bitbar rest api sometimes fails and returns an empty list when searching for a project without indication that a failure occurred. We discussed attempting multiple times during the configuration step as a work around for the hidden failure to reduce the chance of creating a new project with a duplicate name. It would be nice to be more robust however.

However it should be simple to make the detection of a duplicate project a fatal error that terminates the script. This should be extended to making duplicate device groups and devices fail also.

We investigate a better approach of preventing duplicate projects, device groups or devices from being created.

Comment 3

[Andrew Erickson [:aerickson]]

PR to exit on duplicate projects (https://github.com/bclary/mozilla-bitbar-devicepool/pull/89) has been landed.

Comment 4

[Andrew Erickson [:aerickson]]

I think we've permanently squashed our duplicate project issues (was due to finding other user's projects and we now only search for the current user). Closing.