Closed Bug 1566283 Opened 2 years ago Closed 2 years ago

Clickable label area for event listener breakpoint entries is too small

Categories

(DevTools :: Debugger, defect, P3)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: Harald, Assigned: shellyc23)

References

(Depends on 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

Label doesn't stretch to the whole width
25.76 KB, image/png
Details
Bug 1566283 - Increased width of event listener breakpoint clickable area r=davidwalsh
47 bytes, text/x-phabricator-request
Details | Review

What were you doing?

  1. Open the Debugger
  2. Click a row in the Event BP panel, to the right of the panel

What happened?

Nothing.

What should have happened?

Checkbox gets toggled.

Depends on: dbg-frontend
Keywords: good-first-bug

I looked into this, and might have came up with a solution.

By adding width: 100% to the .event-listener-label selector in 'debugger\src\components\SecondaryPanes\EventListeners.css', the label would stretch the whole width.

Let me know what you think

That may work! Give it a shot, open a phabricator patch, and we'll have a look. Thank you!

In EventListeners.css I added width: 100% to the .event-listener-label to increase the width of the clickable area.

Attachment #9080901 - Attachment description: Bug 1566283 - Increased width of event listener breakpoint clickable area r=jlast → Bug 1566283 - Increased width of event listener breakpoint clickable area r=davidwalsh
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a666f60836b7
Increased width of event listener breakpoint clickable area r=davidwalsh

https://hg.mozilla.org/mozilla-central/rev/a666f60836b7

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Assignee: nobody → shellyc23
You need to log in before you can comment on or make changes to this bug.