156630 - email with empty 'subject' crashes mozilla - Trunk [@ MSVCRT.DLL - MimeMessage_close_headers] MimeMessage_close_headers]

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect)

Description

[Damir Perisa]

buildID 2002070904:

emails with empty 'subject' hang mozilla when tried to open

reproducable: with all empty-subject-emails
howto reproduce: send yourself an email with an empty 'subject' line 
and try to open it with mozilla 2002070904 (maybe other builts too)

(many people send emails with empty subject-line, netscape warns the user since
version 4.5 but often users ignore it; and there are other 'stupid' programms
that do not warn you when trying to send an email without a subject :-( but
mozilla must not hang when trying to open them!!)

Comment 1

[Jo Hermans]

WFM on 1.1a build 2002061104 (I know it's old).
Mozilla doesn't allow me to send an empty subject (it will remove the entire
header), but I used my mac.com account to send me an email with an empty header.

Comment 2

[Karsten Düsterloh]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1a+) Gecko/20020709

> Mozilla doesn't allow me to send an empty subject
> (it will remove the entire header),

The crash occurs both without Subject: and with empty Subject:.

Comment 3

[Frederic Bezies]

Confirming this bug. Reproduced it, and send a Talkback -> TB8174254W

Using trunk build 2002071004 - WinXP.

Comment 4

[Olav Vitters]

Attachment: Stacktrace Linux todays CVS

Comment 5

[Sébastien Desvignes]

Seeing this with trunk build 2002070913 Win2000

Talkback :
TB8174031Y
TB8174062K
TB8174128H

Comment 6

[Olivier Cahagne]

Dupe of bug 154753 for sure.

Comment 7

[Olav Vitters]

*** Bug 156671 has been marked as a duplicate of this bug. ***

Comment 8

[Damir Perisa]

i'm not a programmer but here an idea how to solve this bug:  a filter should check emails ariving and add a value (e.g. ''no subject specified'') in the subject-line while the email is downloaded from server 

Comment 9

[Frederic Bezies]

In answer to comment #6 :

crash also happens when trying to view a message in inbox without subject in it.

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

There was a checkin yesterday that didn't null check the return value of
GetHeaderValue() before using it at 

mozilla/mailnews/mime/emitters/src/nsMimeHtmlEmitter.cpp:312.

Comment 11

[rods (gone)]

fixed - I backed out checkin for Bug 156307, reopening 156307

Comment 12

[Damir Perisa]

fix verified in mozilla nightly 2002071104   thx 

Comment 13

[Jay Patel [:jay]]

Adding topcrash+, testcase keywords and Trunk [@ MSVCRT.DLL - 
MimeMessage_close_headers] to summary for future reference.  This *was* a
topcrash with MozillaTrunk builds on 7/10.

Comment 14

[wacheo]

*** Bug 159872 has been marked as a duplicate of this bug. ***