Closed Bug 1566336 Opened 1 year ago Closed 1 year ago

Upstream llvm is moving from svn to git (github), update our code

Categories

(Firefox Build System :: Toolchains, task, P2)

task

Tracking

(firefox-esr68 fixed, firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox-esr68 --- fixed
firefox70 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Regressed 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

With tags:
https://github.com/llvm/llvm-project/releases

The main change is that it is a monorepo with the option
-DLLVM_ENABLE_PROJECTS="clang;libcxx;libcxxabi"
https://llvm.org/docs/GettingStarted.html#getting-started-quickly-a-summary

I am trying a patch

Depends on D38361

clang4.0 is blocked by the same bug as:
https://bugzilla.mozilla.org/show_bug.cgi?id=1564252#c3
undefined symbols
Not sure how to fix this one yet

The two windows issues are just that the CI cannot find git in the PATH.

Assignee: nobody → sledru
Attachment #9078759 - Attachment is obsolete: true
Attachment #9078758 - Attachment description: Bug 1566336 - llvm upstream is (finally) moving to git from svn → Bug 1566336 - llvm upstream is (finally) moving to git from svn r=glandium,andi
Priority: -- → P2
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ba7a3e079e3
Build clang from git rather than subversion. r=glandium

Backed out changeset 4ba7a3e079e3 (Bug 1566336) for static analysis bustage

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&fromchange=4ba7a3e079e3c1ccd685eaa631d17fb126456343&tochange=b90888e32cc1b864509000469d3353c5494e1548&selectedJob=259266297

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/b90888e32cc1b864509000469d3353c5494e1548

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=259266297&repo=mozilla-inbound&lineNumber=1706

[task 2019-07-31T21:33:18.496Z] 21:33:18 INFO - Creating config.status
[task 2019-07-31T21:33:18.742Z] 21:33:18 INFO - Reticulating splines...
[task 2019-07-31T21:33:19.376Z] 21:33:19 INFO - 0:00.67 File already read. Skipping: /builds/worker/workspace/build/src/modules/brotli/moz.build
[task 2019-07-31T21:33:22.697Z] 21:33:22 INFO - 0:04.00 File already read. Skipping: /builds/worker/workspace/build/src/gfx/angle/targets/angle_common/moz.build
[task 2019-07-31T21:33:39.464Z] 21:33:39 INFO - Finished reading 1761 moz.build files in 5.80s
[task 2019-07-31T21:33:39.466Z] 21:33:39 INFO - Read 64 gyp files in parallel contributing 0.00s to total wall time
[task 2019-07-31T21:33:39.467Z] 21:33:39 INFO - Processed into 10985 build config descriptors in 6.47s
[task 2019-07-31T21:33:39.469Z] 21:33:39 INFO - RecursiveMake backend executed in 6.95s
[task 2019-07-31T21:33:39.471Z] 21:33:39 INFO - 3874 total backend files; 3874 created; 0 updated; 0 unchanged; 0 deleted; 37 -> 1419 Makefile
[task 2019-07-31T21:33:39.473Z] 21:33:39 INFO - FasterMake backend executed in 0.55s
[task 2019-07-31T21:33:39.474Z] 21:33:39 INFO - 13 total backend files; 13 created; 0 updated; 0 unchanged; 0 deleted
[task 2019-07-31T21:33:39.475Z] 21:33:39 INFO - Total wall time: 20.75s; CPU time: 19.86s; Efficiency: 96%; Untracked: 0.98s
[task 2019-07-31T21:33:39.856Z] 21:33:39 INFO - Configure complete!
[task 2019-07-31T21:33:39.856Z] 21:33:39 INFO - Be sure to run |mach build| to pick up any changes
[task 2019-07-31T21:33:39.900Z] 21:33:39 INFO - Return code: 0
[task 2019-07-31T21:33:40.407Z] clang-tidy unable to locate package.
[task 2019-07-31T21:33:40.424Z] 21:33:40 WARNING - setting return code to 2
[task 2019-07-31T21:33:40.425Z] 21:33:40 FATAL - 'mach static-analysis autotest --intree-tool' did not run successfully. Please check log for errors.
[task 2019-07-31T21:33:40.425Z] 21:33:40 FATAL - Running post_fatal callback...
[task 2019-07-31T21:33:40.425Z] 21:33:40 FATAL - Exiting -1
[task 2019-07-31T21:33:40.426Z] 21:33:40 INFO - [mozharness: 2019-07-31 21:33:40.426010Z] Finished static-analysis-autotest step (failed)
[task 2019-07-31T21:33:40.426Z] 21:33:40 INFO - Running post-run listener: _parse_build_tests_ccov
[task 2019-07-31T21:33:40.426Z] 21:33:40 INFO - Running post-run listener: _shutdown_sccache
[task 2019-07-31T21:33:40.427Z] 21:33:40 INFO - Running command: ['/builds/worker/workspace/build/src/sccache/sccache', '--stop-server'] in /builds/worker/workspace/build/src
[task 2019-07-31T21:33:40.427Z] 21:33:40 INFO - Copy/paste: /builds/worker/workspace/build/src/sccache/sccache --stop-server

Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5aba1c487f2
Build clang from git rather than subversion. r=glandium
Flags: needinfo?(mh+mozilla)
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Depends on: 1573769

Comment on attachment 9144527 [details]
Bug 1566336 - Build clang from git rather than subversion.

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: The LLVM subversion server was turned off, and if toolchain jobs trigger on the esr68 branch for some random reason, they fail. This is a backport of https://hg.mozilla.org/mozilla-central/rev/c5aba1c487f2 with a few adjustments for esr68 (one context change made it not apply cleanly, and a few adjustements were needed for bug 1601701, which had been uplifted)
  • User impact if declined: Build failures on automation
  • Fix Landed on Version: 70
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Only changes how we get the sources for clang.
  • String or UUID changes made by this patch:
Attachment #9144527 - Flags: approval-mozilla-esr68?
Regressions: 1634788

Comment on attachment 9144527 [details]
Bug 1566336 - Build clang from git rather than subversion.

Avoid broken toolchain tasks in the event of needing to rebuild clang on ESR68 by pointing to the git repo instead of SVN. No change to the actual clang version we use for builds there. Approved for ESR68.

Attachment #9144527 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+
You need to log in before you can comment on or make changes to this bug.