drop postBackoutMergeCheck from bugherder because it can yield false positives (backout in 'merge' category despite not being one)
Categories
(Tree Management :: Bugherder, defect)
Tracking
(Not tracked)
People
(Reporter: aryx, Unassigned)
Details
The postBackoutMergeCheck method
// [...] if we have two sequential backouts which both
// claim to affect the same changeset, then the second is a merge backout
As far as I understand it, a "backout merge" is meant:
- changeset(s) get backed out on tree A and create new commit changesetBackout1
- tree A gets merged into tree B and the reason used in the past was about the backout, e.g. "Back out changeset <hex> (bug <number>) for <reason>. a=merge", similar to changesetBackout1. Changeset is changesetBackout2
Nowadays, changesetBackout2 has "Merge tree A to tree B. a=merge" as commit message and the use case doesn't occur anymore, but false positives like for https://bugherder.mozilla.org/?cset=6776193254443dd4ea45e121d083c2f8508f7da5&tree=mozilla-central which lists https://hg.mozilla.org/mozilla-central/rev/a851ef1c46e0 under the merges because other changesets from the same bug got backed out in the previous changeset.
Please correct me if anything of the workflow above is wrong or a use case has been missed, else I will remove that code.
I'm not familiar enough with this part of the codebase, and I'm way out of the loop on actually using bugherder to know for sure, but your description sounds correct.
To be honest, I never really used either the "backout" or "merge" sections of bugherder much. Pulsebot or the person pushing the backout commits in the first place usually comments for backouts.
|
||
Comment 2•6 years ago
|
||
What does this have to do with Intermittent Failures View??
|
Reporter | |
Comment 3•6 years ago
|
||
Sorry, likely changed the component by typing when the list still had focus.
Description
•