1566362 - Scalar devtools.toolbox.tabs_reordered expired in Firefox 65

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

The telemetry scalar monitoring devtools tab reordering expired in 65.

However the scalar definition is still in tree: https://searchfox.org/mozilla-central/rev/07f7390618692fa4f2a674a96b9b677df3a13450/toolkit/components/telemetry/Scalars.yaml#1808-1823

and we still have the code to record it: https://searchfox.org/mozilla-central/rev/07f7390618692fa4f2a674a96b9b677df3a13450/devtools/client/framework/toolbox-tabs-order-manager.js#192-196

We should either update the expires field or remove the scalar & code.

Comment 1

[Julian Descottes [:jdescottes]]

Hi Harald, do you think it would be valuable to revive this probe?

Comment 2

[Julian Descottes [:jdescottes]]

As I realised many more probes were impacted by this, I filed Bug 1566383

Comment 3

[Julian Descottes [:jdescottes]]

Clearing the needinfo here since Harald already answered in the main meta Bug 1566383
devtools.toolbox.tabs_reordered should be revived and extended if possible.

Daisuke: since you worked on the initial implementation would you like to handle this?

Comment 4

[Julian Descottes [:jdescottes]]

As discussed on Slack, I will take the bug

Comment 5

[Daisuke Akatsuka (:daisuke)]

Thank you so much Julian!

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1566362 - Set expires to "never" for devtools tabs_reordered scalar

Per Harald's feedback on https://bugzilla.mozilla.org/show_bug.cgi?id=1566383#c2

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: bug_1566362_data_review.txt

We are trying to cleanup the currently expired scalars in DevTools. For this one we decided it would be better to keep it and revive it.

Comment 8

[Julian Descottes [:jdescottes]]

Harald, would you like to own/monitor this probe (cf discussion in phabricator https://phabricator.services.mozilla.com/D39198#inline-237481) ?

Comment 9

[:Harald Kirschner :digitarald]

wfm (even though my email is on a few probes, I have not received telemetry emails in a while from any system)

Comment 10

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9080338 [details]
bug_1566362_data_review.txt

Grabbing this review since Francois is no longer at Mozilla. You can consult https://wiki.mozilla.org/Firefox/Data_Collection for an up-to-date list of stewards.

Renewing a collection just because it’s expired may be a signal that the collection is not necessary. Have these probes been evaluated since they were implemented? Do you have plans to make changes to tab order in the future?

Harald’s commitment to monitoring the probe should be reflected in Scalars.yaml.

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, Scalars.yaml.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, Firefox telemetry opt-out.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

Julian nominated himself in the data review request, but per discussion in the bug, Harald will be responsible for monitoring the collection.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, interaction data.

5) Is the data collection request for default-on or default-off?

Default-on.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent collection.

9) Does the data collection use a third-party collection tool?

No.

Comment 11

[Julian Descottes [:jdescottes]]

(In reply to Tim Smith 👨‍🔬 [:tdsmith] from comment #10)

Comment on attachment 9080338 [details]
bug_1566362_data_review.txt

Grabbing this review since Francois is no longer at Mozilla. You can consult
https://wiki.mozilla.org/Firefox/Data_Collection for an up-to-date list of
stewards.

Ah thanks for grabbing this! Thanks for the link.
By any chance do you also accept data-reviews on phabricator, where we could use a reviewer group to avoid assigning to a single person?

Renewing a collection just because it’s expired may be a signal that the
collection is not necessary. Have these probes been evaluated since they
were implemented? Do you have plans to make changes to tab order in the
future?

There was more discussion on the meta bug https://bugzilla.mozilla.org/show_bug.cgi?id=1566383 . We looked at all the currently expired probes. We removed some probes and kept others, although I don't have specific insights to share about this one. Harald might be able to share why we still want to monitor this.

Harald’s commitment to monitoring the probe should be reflected in
Scalars.yaml.

Yep will update it now

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b9934860997
Set expires to "never" for devtools tabs_reordered scalar r=janerik

Comment 13

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/7b9934860997