1566367 - Implement a new GV API for Glean streaming telemetry

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Description

[Alessio Placitelli [:Dexter]]

This is for implementing the new GeckoView streaming API described in the proposal to integrate GeckoView and the Glean SDK, in order to exfiltrate Gecko metrics to Fenix (and other android products based off a-c).

Comment 1

[Eugen Sawin [:esawin]]

Attachment: Bug 1566367 - [A.0] From bug 1566366 - Redirect GV Streaming Telemetry to a delegate.

Comment 2

[Eugen Sawin [:esawin]]

Attachment: Bug 1566367 - [1.0] Add GV RuntimeTelemetry delegate.

Depends on D38897

Comment 3

[Eugen Sawin [:esawin]]

Attachment: Bug 1566367 - [2.0] Add streaming telemetry Gecko-GV bridge.

Depends on D38898

Comment 4

[Eugen Sawin [:esawin]]

Attachment: Bug 1566367 - [3.0] Add GVE example telemetry delegate.

Depends on D38899

Comment 6

[Chris Peterson [:cpeterson]]

Agi is picking up the Glean/GV work while Eugen is out on leave. This bug is blocked waiting on the Glean work in Gecko.

Comment 7

[Alessio Placitelli [:Dexter]]

(In reply to Chris Peterson [:cpeterson] from comment #6)

Agi is picking up the Glean/GV work while Eugen is out on leave. This bug is blocked waiting on the Glean work in Gecko.

This is not necessarily blocked on bug 1566366: this is for providing the GV API and the JNI endpoints, bug 1566366 is for introducing a telemetry delegate. Implementing the delegate to hook up GV and Telemetry (patch [2.0] in this bug) can be moved in a follow-up bug or as part of bug 1566366 .

My only concern with this would be that we had to clear the the outstanding interface question to avoid changing the GV API.

Comment 8

[Chris Peterson [:cpeterson]]

I'm editing a bunch of GeckoView bugs. If you'd like to filter all this bugmail, search and destroy emails containing this UUID:

e88a5094-0fc0-4b7c-b7c5-aef00a11dbc9

Comment 9

[Alessio Placitelli [:Dexter]]

(In reply to Chris Peterson [:cpeterson] from comment #8)

I'm editing a bunch of GeckoView bugs. If you'd like to filter all this bugmail, search and destroy emails containing this UUID:

Hey Chris, is P2 indicating that the priority on this dropped? This is a vital piece of the GeckoView + Glean SDK integration :)

Comment 10

[Chris Peterson [:cpeterson]]

(In reply to Alessio Placitelli [:Dexter] from comment #9)

Hey Chris, is P2 indicating that the priority on this dropped? This is a vital piece of the GeckoView + Glean SDK integration :)

I'll restore priority P1. Agi is working on this bug.

Comment 11

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1566367 - WIP DO NOT LAND

Comment 12

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1566367 - [0.0] Fix javadoc in WebExtensionController.

Comment 13

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1566367 - [4.0] Add test for onTelemetryReceived.

Comment 14

[[ex-Mozilla] Agi Sferro | :agi]

Landing the javadoc fix

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adb5e7efc20a
[0.0] Fix javadoc in WebExtensionController. r=snorp

Comment 16

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/adb5e7efc20a

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf556b5d97f1
[1.0] Add GV RuntimeTelemetry delegate. r=snorp
https://hg.mozilla.org/integration/autoland/rev/7c7e74beed99
[2.0] Add streaming telemetry Gecko-GV bridge. r=snorp,chutten
https://hg.mozilla.org/integration/autoland/rev/45d2398750a2
[3.0] Add GVE example telemetry delegate. r=snorp
https://hg.mozilla.org/integration/autoland/rev/3f5971e7dc98
[4.0] Add test for onTelemetryReceived. r=chutten,Dexter,snorp

Comment 18

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cf556b5d97f1
https://hg.mozilla.org/mozilla-central/rev/7c7e74beed99
https://hg.mozilla.org/mozilla-central/rev/45d2398750a2
https://hg.mozilla.org/mozilla-central/rev/3f5971e7dc98

Comment 19

[[ex-Mozilla] Agi Sferro | :agi]

🎉