1566391 - Review expired histograms for the Memory panel

Status: RESOLVED FIXED

(DevTools :: Memory, task)

Description

[Julian Descottes [:jdescottes]]

We have several expired telemetry histograms for the memory panel. We should either remove them entirely or update their expiry.

Histograms:

• DEVTOOLS_MEMORY_TAKE_SNAPSHOT_COUNT (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_IMPORT_SNAPSHOT_COUNT (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_EXPORT_SNAPSHOT_COUNT (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_FILTER_CENSUS (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_DIFF_CENSUS (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_INVERTED_CENSUS (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_BREAKDOWN_CENSUS_COUNT (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_DOMINATOR_TREE_COUNT (expired in 56) (searchfox)
• DEVTOOLS_MEMORY_BREAKDOWN_DOMINATOR_TREE_COUNT (expired in 56) (searchfox)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1566391 - Remove expired and unused DevTools Memory panel histograms

Depends on D38169

The code in DevTools using the histograms was already removed in Bug 1381178.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8723eeacb6c6
Remove expired and unused DevTools Memory panel histograms r=janerik

Comment 3

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 8723eeacb6c6 (bug 1566391) for build bustage at deps/TelemetryHistogramEnums.h.stub

Backout: https://hg.mozilla.org/integration/autoland/rev/1a6611fbae3469fe103dbf5e98c2a19c578982f4

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=8723eeacb6c6a6dd2e748f5209ad242f769bc909

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=256893178&repo=autoland&lineNumber=3840

task 2019-07-17T10:06:37.818Z] 10:06:37 INFO - Exception KeyError: KeyError(139758846621440,) in <module 'threading' from '/usr/lib/python2.7/threading.pyc'> ignored
[task 2019-07-17T10:06:37.819Z] 10:06:37 INFO - backend.mk:61: recipe for target '.deps/TelemetryHistogramEnums.h.stub' failed
[task 2019-07-17T10:06:37.819Z] 10:06:37 ERROR - make[4]: *** [.deps/TelemetryHistogramEnums.h.stub] Error 1
[task 2019-07-17T10:06:37.819Z] 10:06:37 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2019-07-17T10:06:37.819Z] 10:06:37 INFO - make[4]: *** Waiting for unfinished jobs....
[task 2019-07-17T10:06:37.934Z] 10:06:37 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/base'
[task 2019-07-17T10:06:37.934Z] 10:06:37 INFO - xpcom/base/gk_rust_utils_ffi_generated.h.stub
[task 2019-07-17T10:06:37.934Z] 10:06:37 INFO - /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python -m mozbuild.action.file_generate /builds/worker/workspace/build/src/layout/style/RunCbindgen.py generate gk_rust_utils_ffi_generated.h .deps/gk_rust_utils_ffi_generated.h.pp .deps/gk_rust_utils_ffi_generated.h.stub /builds/worker/workspace/build/src/xpcom/rust/gkrust_utils
[task 2019-07-17T10:06:37.934Z] 10:06:37 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/base'
[task 2019-07-17T10:06:37.934Z] 10:06:37 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/base'
[task 2019-07-17T10:06:37.934Z] 10:06:37 INFO - ../../config/nsinstall -R -m 644 'gk_rust_utils_ffi_generated.h' '../../dist/include/mozilla'
[task 2019-07-17T10:06:37.934Z] 10:06:37 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/base'
[task 2019-07-17T10:06:38.096Z] 10:06:38 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2019-07-17T10:06:38.096Z] 10:06:38 INFO - toolkit/components/telemetry/TelemetryHistogramData.inc.stub
[task 2019-07-17T10:06:38.096Z] 10:06:38 INFO - /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python -m mozbuild.action.file_generate /builds/worker/workspace/build/src/toolkit/components/telemetry/build_scripts/gen_histogram_data.py main TelemetryHistogramData.inc .deps/TelemetryHistogramData.inc.pp .deps/TelemetryHistogramData.inc.stub /builds/worker/workspace/build/src/toolkit/components/telemetry/Histograms.json /builds/worker/workspace/build/src/dom/base/UseCounters.conf /builds/worker/workspace/build/src/dom/base/nsDeprecatedOperationList.h
[task 2019-07-17T10:06:38.096Z] 10:06:38 INFO - The following entries are orphaned and should be removed from histogram-whitelists.json:
[task 2019-07-17T10:06:38.097Z] 10:06:38 INFO - DEVTOOLS_MEMORY_BREAKDOWN_CENSUS_COUNT, DEVTOOLS_MEMORY_BREAKDOWN_DOMINATOR_TREE_COUNT, DEVTOOLS_MEMORY_DOMINATOR_TREE_COUNT, DEVTOOLS_MEMORY_EXPORT_SNAPSHOT_COUNT, DEVTOOLS_MEMORY_IMPORT_SNAPSHOT_COUNT, DEVTOOLS_MEMORY_TAKE_SNAPSHOT_COUNT
[task 2019-07-17T10:06:38.098Z] 10:06:38 INFO - Some errors occurred
[task 2019-07-17T10:06:38.098Z] 10:06:38 INFO - Exception KeyError: KeyError(140544498280192,) in <module 'threading' from '/usr/lib/python2.7/threading.pyc'> ignored
[task 2019-07-17T10:06:38.098Z] 10:06:38 INFO - backend.mk:51: recipe for target '.deps/TelemetryHistogramData.inc.stub' failed
[task 2019-07-17T10:06:38.098Z] 10:06:38 ERROR - make[4]: *** [.deps/TelemetryHistogramData.inc.stub] Error 1

Comment 4

[Julian Descottes [:jdescottes]]

Sorry about that! The histograms were listed several times in histogram-whitelists.json and I forgot to remove all of them.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e42d08f69438
Remove expired and unused DevTools Memory panel histograms r=janerik

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e42d08f69438