Closed Bug 1566398 Opened 2 years ago Closed 2 years ago

Review expired scalars for inspector changes panel

Categories

(DevTools :: Inspector: Changes, task, P3)

task

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: jdescottes, Assigned: rcaliman)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

We have several expired scalars for the changes panel. We should either remove them entirely or update their expiry.

Scalars:

  • devtools.changesview copy (expired in 69) (searchfox)
  • devtools.changesview contextmenu (expired in 69) (searchfox)
  • devtools.changesview contextmenu_copy (expired in 69) (searchfox)

Hi Razvan!

The scalars mentioned above just expired, I guess you want to update the expiry date before the end of the 70 cycle?
(and maybe there's already a bug filed, but couldn't find it)

Flags: needinfo?(rcaliman)

Thanks for logging this, Julian. I will remove the expired probes.

We didn't have a tracking bug. We were expecting an automated email reminder about their expiration, but one didn't come.

Assignee: nobody → rcaliman
Status: NEW → ASSIGNED
Flags: needinfo?(rcaliman)
Target Milestone: --- → Firefox 70

(In reply to Razvan Caliman [:rcaliman] from comment #2)

Thanks for logging this, Julian. I will remove the expired probes.

For info I asked Harald's input on all our expired probes and he suggested to extend the ones listed here (see meta bug comment bug 1566383 comment 2). This is just an input though, and :mbalfanz is the listed owner for those probes so as long as Martin agrees to remove them that's fine :)

We didn't have a tracking bug. We were expecting an automated email reminder about their expiration, but one didn't come.

We used to have emails for that, but I haven't seen one in a long time.
Let's ask :janerik if anything is wrong with email notifications for expired probes at the moment?

Flags: needinfo?(jrediger)

That is a very good question (I was bitten by this myself). I'll try to find out with my team (and leaving the ni? as a reminder to reply back here)

Ah! Our alerting system (cerberus) only handles histograms. It does not send expiring alerts for scalars unfortunately.

Flags: needinfo?(jrediger)

Thanks for the quick investigation! We'll be careful around scalars then :)

I discussed with Razvan to remove the probes listed here :)

Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f0b33abecd0
Remove expired scalar telemetry probes for Changes panel. r=gl
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.